Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add group_measurements_by_instance_label flag to perfmon configuration (#8688)" #11001

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 28, 2019

Windows tests are failing, Windows builds were not run on original PR (#8688).

This reverts commit fbee6a2.

@jsoriano
Copy link
Member Author

Failing test in jenkins is not related.

@andrewkroh
Copy link
Member

I tried to fix the test, but the code isn't behaving as described in the documentation or the test case. The test case that's failing says that it should group everything into a single event but it's actually producing two events (so some grouping is working).

--- PASS: TestGroupByInstance (1.02s)
    pdh_integration_windows_test.go:378: {
          "processor": {
            "name": "_Total",
            "time": {
              "idle": {
                "average": {
                  "ns": 10932693.47826087
                }
              },
              "pct": 0
            }
          }
        }
    pdh_integration_windows_test.go:378: {
          "disk": {
            "bytes": {
              "read": {
                "total": 0
              }
            }
          }
        }

@jsoriano jsoriano merged commit 70fd801 into elastic:master Feb 28, 2019
@jsoriano jsoriano deleted the revert-perfmon-grouping branch March 1, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants