Push events even when there's no cloudwatch data #11023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
Metricbeat
3 tasks
ruflin
approved these changes
Mar 7, 2019
| @@ -32,8 +31,14 @@ see https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp.html[Te | |||
| aws> sts get-session-token --serial-number arn:aws:iam::1234:mfa/your-email@example.com --token-code 456789 --duration-seconds 129600 | |||
| ---- | |||
|
|
|||
| Specific permissions needs to be added into the IAM user's policy to authorize Metricbeat to collect AWS monitoring metrics. Please | |||
| see documentation under each metricset for required permissions. | |||
| Since temporary security credentials are short term, after they expire, the user needs to generate new ones and modify | |||
There was a problem hiding this comment.
This paragraph sounds like someone could just replace the credentials and it would reload. This is true if reload is enabled, but by default it's off.
kaiyan-sheng
added a commit
that referenced
this pull request
Mar 11, 2019
kaiyan-sheng
removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instance is not in running state, there will not be metrics in Cloudwatch. But it's till valuable to push an event about this instance. So users can see there are instances hanging around that's not working.
With this PR, instances in stopped state are reported as well. Please see kibana picture below:
This PR also updated the documentations for ec2, please see #11009 for more details.