Cherry-pick to 6.6: Add support in jolokia get response for single value (#11075) #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support in jolokia get response for single value * Use reflect.TypeOf to check attribute and value type * Add changelog * Replace reflect by type switching * Fix indentation for comments (cherry picked from commit c238ea2)
jsoriano
reviewed
Mar 6, 2019
| "event": { | ||
| "dataset": "jolokia.testnamespace", | ||
| "duration": 115000, | ||
| "module": "jolokia" |
There was a problem hiding this comment.
Same as in the backport to 6.7, I don't think this has to change.
jsoriano
approved these changes
Mar 6, 2019
|
jenkins, test this please |
|
@kaiyan-sheng Can you add / fix labels on this PR? |
Done |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lue (elastic#11075) (elastic#11117) * Add support in jolokia get response for single value (elastic#11075) (cherry picked from commit 1d966f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original message:
Jolokia module fails to parse some responses fetched using the GET method with error:
This is because value field can be a map[string]interface or it can also be just a float.
(cherry picked from commit c238ea2)