-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use beat.timezone instead of event.timezone #11164
Merged
ycombinator
merged 2 commits into
elastic:6.7
from
ycombinator:bugfix-timezone-field-67
Mar 11, 2019
Merged
Use beat.timezone instead of event.timezone #11164
ycombinator
merged 2 commits into
elastic:6.7
from
ycombinator:bugfix-timezone-field-67
Mar 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6.7 the add_locale processor will set the beat.timezone field (as opposed to event.timezone, which is set starting 7.0). So any ingest pipelines looking for the timezone field should look for beat.timezone, not event.timezone.
ycombinator
added
bug
review
needs_backport
PR is waiting to be backported to other branches.
v6.7.0
v6.6.2
labels
Mar 8, 2019
webmat
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cachedout
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. This looks like just what's needed!
jenkins, test this |
kaiyan-sheng
approved these changes
Mar 11, 2019
ycombinator
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Mar 11, 2019
ycombinator
added a commit
that referenced
this pull request
Mar 13, 2019
#11195) Cherry-pick of PR #11164 to 6.6 branch. Original message: In 6.x the `add_locale` processor will [set the `beat.timezone` field](https://github.com/elastic/beats/blob/6.7/libbeat/processors/add_locale/add_locale.go#L89) (as opposed to `event.timezone`, which is [set starting 7.0](https://github.com/elastic/beats/blob/master/libbeat/processors/add_locale/add_locale.go#L89)). So any 6.x ingest pipelines looking for the timezone field should look for `beat.timezone`, not `event.timezone`. Fixes #11055.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…timezone (elastic#11195) Cherry-pick of PR elastic#11164 to 6.6 branch. Original message: In 6.x the `add_locale` processor will [set the `beat.timezone` field](https://github.com/elastic/beats/blob/6.7/libbeat/processors/add_locale/add_locale.go#L89) (as opposed to `event.timezone`, which is [set starting 7.0](https://github.com/elastic/beats/blob/master/libbeat/processors/add_locale/add_locale.go#L89)). So any 6.x ingest pipelines looking for the timezone field should look for `beat.timezone`, not `event.timezone`. Fixes elastic#11055.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6.x the
add_locale
processor will set thebeat.timezone
field (as opposed toevent.timezone
, which is set starting 7.0). So any 6.x ingest pipelines looking for the timezone field should look forbeat.timezone
, notevent.timezone
.Fixes #11055.