Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use beat.timezone instead of event.timezone #11164

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Mar 8, 2019

In 6.x the add_locale processor will set the beat.timezone field (as opposed to event.timezone, which is set starting 7.0). So any 6.x ingest pipelines looking for the timezone field should look for beat.timezone, not event.timezone.

Fixes #11055.

In 6.7 the add_locale processor will set the beat.timezone field (as opposed to event.timezone, which is set starting 7.0). So any ingest pipelines looking for the timezone field should look for beat.timezone, not event.timezone.
@ycombinator ycombinator added bug review needs_backport PR is waiting to be backported to other branches. v6.7.0 v6.6.2 labels Mar 8, 2019
@ycombinator ycombinator requested review from webmat, ruflin, kaiyan-sheng and a team March 8, 2019 17:26
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This looks like just what's needed!

@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator merged commit 065ccc4 into elastic:6.7 Mar 11, 2019
@ycombinator ycombinator deleted the bugfix-timezone-field-67 branch March 11, 2019 19:31
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Mar 11, 2019
ycombinator added a commit that referenced this pull request Mar 13, 2019
#11195)

Cherry-pick of PR #11164 to 6.6 branch. Original message: 

In 6.x the `add_locale` processor will [set the `beat.timezone` field](https://github.com/elastic/beats/blob/6.7/libbeat/processors/add_locale/add_locale.go#L89) (as opposed to `event.timezone`, which is [set starting 7.0](https://github.com/elastic/beats/blob/master/libbeat/processors/add_locale/add_locale.go#L89)). So any 6.x ingest pipelines looking for the timezone field should look for `beat.timezone`, not `event.timezone`.

Fixes #11055.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…timezone (elastic#11195)

Cherry-pick of PR elastic#11164 to 6.6 branch. Original message: 

In 6.x the `add_locale` processor will [set the `beat.timezone` field](https://github.com/elastic/beats/blob/6.7/libbeat/processors/add_locale/add_locale.go#L89) (as opposed to `event.timezone`, which is [set starting 7.0](https://github.com/elastic/beats/blob/master/libbeat/processors/add_locale/add_locale.go#L89)). So any 6.x ingest pipelines looking for the timezone field should look for `beat.timezone`, not `event.timezone`.

Fixes elastic#11055.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants