[Metricbeat] Fix wrong alias in rabbitmq module #11284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rabbitmq.node.name was duplicated and alias pointed to itself * rabbitmq.connection.name was falsely migrated to `rabbitmq.name` Also adding tests to Filebeat and Metricbeat to ensure this does not happen again in the future. Closes elastic#11271
ruflin
added
bug
module
review
Metricbeat
sayden
approved these changes
Mar 18, 2019
jsoriano
reviewed
Mar 18, 2019
metricbeat/docs/fields.asciidoc
Outdated
| @@ -20543,12 +20533,10 @@ connection | |||
|
|
|||
|
|
|||
|
|
|||
| *`rabbitmq.connection.name`*:: | |||
| *`rabbitmq.connection.connection.name`*:: | |||
There was a problem hiding this comment.
Shouldn't this be rabbit.connection.name as before?
|
@jsoriano Thanks for catching, new version pushed. |
jsoriano
approved these changes
Mar 18, 2019
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Mar 18, 2019
* rabbitmq.node.name was duplicated and alias pointed to itself * rabbitmq.connection.name was falsely migrated to `rabbitmq.name` Also adding tests to Filebeat and Metricbeat to ensure this does not happen again in the future. Closes elastic#11271 (cherry picked from commit feaef40)
ruflin
added
v7.0.0
and removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rabbitmq.nameAlso adding tests to Filebeat and Metricbeat to ensure this does not happen again in the future.
Closes #11271