Prevent connection error overflow on windows #11406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small modification assure that Metricbeat closes the connections in case of errors. As reported by #11393. The thing is that on windows you have to install openssl to enable postgresql secure connections, the default is to use insecure connection. While pq library uses by default security connections. So the library is throwing an error: pq: SSL is not enabled on the server and not closing connections resulting on an overflow of connections if you set the period below 5 seconds.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
adriansr
added
bug
in progress
adriansr
reviewed
Mar 23, 2019
| @@ -57,12 +57,13 @@ func New(base mb.BaseMetricSet) (mb.MetricSet, error) { | |||
| // of an error set the Error field of mb.Event or simply call report.Error(). | |||
| func (m *MetricSet) Fetch(reporter mb.ReporterV2) { | |||
| db, err := sql.Open("postgres", m.HostData().URI) | |||
| defer db.Close() | |||
There was a problem hiding this comment.
What happens when db is nil?
There was a problem hiding this comment.
Added a condition to check for it
|
Library related problem, closing pull request for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small modification assure that Metricbeat closes the connections in case of errors. As reported by #11393.
The thing is that on windows you have to install openssl to enable postgresql secure connections, the default is to use insecure connection. While pq library uses by default secure connections.
So the library is throwing an error: pq: SSL is not enabled on the server and not closing connections resulting on an overflow of connections if you set the period below 5 seconds.