Add autodiscover to libbeat modules list in fields generator #11474
Conversation
Add autodiscover providers to the list of libbeat modules in fields generator.
|
Do these fields really make sense for all beats? |
|
@graphaelli I think we need to ask the question differently: Does Jolokia autodiscovery make sense for all Beats (and with it the fields). Right now all autodiscovery providers are available in all Beats. I agree that this is something we should potentially change. Then only the Beats that use the provider, also have the fields. |
I was actually being deliberate there. I'm pretty sure the answer to your version is no. However, apm-server has inherited fields from libbeat that are not relevant to it for awhile and simply not filled them in. In other cases, fields are inherited and filled in differently than they might be in other beats, for example those defined by the host metadata processor. This change opens the door to many more of those kinds of fields, that is those specific to only certain types of beats, and I figured I'd start a discussion on whether that makes sense. For now in apm-server, I've proposed we ignore all autodiscover fields for now. |
|
@graphaelli +1 on having this discussion. Do you mind opening a separate issue for it? Did not check the apm-server code in detail, but does it mean all the autodiscovery code is removed or only the fields? |
|
#11535 to continue the discussion. APM server currently omits autodiscovery documentation and fields only, not code. |
…#11474) Add autodiscover providers to the list of libbeat modules in fields generator. Move jolokia autodiscover fields added in elastic#10925 to the provider.
Add autodiscover providers to the list of libbeat modules in fields
generator, so autodiscover providers can define their own fields
as processors do.
Move jolokia autodiscover fields added in #10925 to the provider.