Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds float attributes in breaking changes #11581

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 2, 2019

Related to elastic/stack-docs#256

This PR adds float attributes to the Beats breaking changes, so that they can be re-used by the Installation and Upgrade Guide. Otherwise, we receive the following messages:

INFO:build_docs:asciidoctor: WARNING: ../../../../beats/libbeat/docs/breaking.asciidoc: line 37: section title out of sequence: expected level 2, got level 3
INFO:build_docs:asciidoctor: WARNING: ../../../../beats/libbeat/docs/breaking.asciidoc: line 49: section title out of sequence: expected level 2, got level 3

Alternatively, we could change the chunking of the Installation and Upgrade Guide, so if this PR is unacceptable, please just let me know.

@lcawl lcawl requested a review from dedemorton April 2, 2019 00:08
@lcawl lcawl requested a review from a team as a code owner April 2, 2019 00:08
@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Apr 2, 2019
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit f0e288b into elastic:master Apr 2, 2019
@lcawl lcawl deleted the float-breaking-changes branch April 2, 2019 15:04
dedemorton pushed a commit to dedemorton/beats that referenced this pull request May 8, 2019
dedemorton pushed a commit to dedemorton/beats that referenced this pull request May 9, 2019
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants