-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #11346 to 6.7: Don't use multiline options in Logstash module with json format #11601
Conversation
(cherry picked from commit f76f293)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can't 100% follow how this test magically works for both versions (if it does).
That's because it doesn't 🤦♂️. I had to hack my |
@ruflin I backported these lines as part of this PR: https://github.com/elastic/beats/pull/9959/files#diff-bc529fe61de07bbc833c8b84fd86cd17R125. Now the tests should "magically" work for both versions: plain and json. |
jenkins, test this |
CI is failing for the
There are no other failures in this PR's CI build. So I'm going to merge it. |
Cherry-pick of PR #11346 to 6.7 branch. Original message:
Multiline options were being applied to json log files with unexpected
results as several lines joined or lines lost.