[Fix] Do not hide error on http failure #11604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small re-ordering.
When http.Do call fails inside
elasticsearch.client.execHTTPRequestit returns statusCode0and error.This is swallowed by check
status != OKresulting in a messageerror from the server, response code:0.The real reason behind this failure is hidden and not even logged.
This PR checks for error before checking for
status != okso in a case when an error is provided, it is logged in another case, we're just logging that status is not OK.I guess err will not be set when status is 200 anyways, but I left the check there