Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove count field from filebeat event #1166

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Mar 16, 2016

This closes #778

Remove count as required field from system tests checks

This closes elastic#778

Remove count as required field from system tests checks
@tsg
Copy link
Contributor

tsg commented Mar 16, 2016

LGTM.

@ruflin
Copy link
Member Author

ruflin commented Mar 16, 2016

@andrewkroh I didn't check in detail why, but it seems like the EnsureField functions don't work as expected as I didn't change it: https://github.com/elastic/beats/blob/master/libbeat/common/mapstr.go#L91-L91 I assume the reason is that a copy and not a reference is passed, so the copy is modified. Perhaps we should have a closer look at this in an other PR?

@andrewkroh
Copy link
Member

The method is written correctly (maps are passed by reference). It just isn't called in libbeat (anymore?). To my surprise it's only invoked by Packetbeat.

@ruflin
Copy link
Member Author

ruflin commented Mar 16, 2016

@andrewkroh Will you have a look at that?

@andrewkroh
Copy link
Member

I don't think there is anything to look into. I think that is the behavior we want because this means count is not required to be included in the data produced by all Beats.

@tsg
Copy link
Contributor

tsg commented Mar 16, 2016

Yes, I think @urso moved the check for it to Packetbeat.

tsg added a commit that referenced this pull request Mar 16, 2016
Remove count field from filebeat event
@tsg tsg merged commit a3c664f into elastic:master Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat field "count" is created directly under the root of an event
3 participants