-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export function template #11923
Export function template #11923
Conversation
e58c3c2
to
ff862ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it, but code looks good nice refactoring @kvch, could we add a simple python system test to make sure it work?
a5228d7
to
fa6ee74
Compare
The above is weird, It's not in our code it's in the python library that we use. |
I've tested the |
jenkins test this |
9565ae5
to
7086fab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a few minors comments concerning missing godoc and also a suggestion for the changelog, otherwise everything else LGTM.
Failure appears to be related to the changes in this PR. |
Failing tests are unrelated. |
A new subcommand is added under
export
namedfunction
. This command prints the loadable template to stdout for enabled functions.I extracted generating templates from
CLIManager
. Now it has aTemplateBuilder
which constructs the template for the manager. A template builder can be retrieved from a provider, as generating templates is specific to providers. Thus,CLIManager
does not need to know about the provider anymore.TODO