Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing logstash-xpack.yml module configuration variant #12005

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 1, 2019

This PR introduces the modules.d/logstash-xpack.yml module configuration variant file. Due to this, users can easily enable the logstash Metricbeat module for Stack Monitoring, like so:

metricbeat modules enable logstash-xpack

@ycombinator ycombinator requested review from a team as code owners May 1, 2019 00:24
@ycombinator ycombinator added Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. review Feature:Stack Monitoring v7.2.0 v8.0.0 labels May 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring

@ycombinator ycombinator requested a review from ruflin May 1, 2019 00:47
@cachedout
Copy link
Contributor

Do you think this needs a docs update as well?

@ycombinator
Copy link
Contributor Author

Do you think this needs a docs update as well?

Yes, good call. I don't think there's any docs to update in the Beats repo but when we write the Logstash equivalent of https://www.elastic.co/guide/en/elasticsearch/reference/master/configuring-metricbeat.html and https://www.elastic.co/guide/en/kibana/master/monitoring-metricbeat.html, we'll want to mention the step where user's enable this module variant.

@ycombinator ycombinator added v7.3.0 and removed v7.2.0 labels Jun 20, 2019
@ycombinator
Copy link
Contributor Author

jenkins, test this

2 similar comments
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator merged commit b3d6b14 into elastic:master Jun 27, 2019
@ycombinator ycombinator deleted the mb-ls-xp branch June 27, 2019 03:45
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants