Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove count field from the Packetbeat event #1210

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Remove count field from the Packetbeat event #1210

merged 1 commit into from
Mar 31, 2016

Conversation

monicasarbu
Copy link
Contributor

Similar with the other Beats, removing the count field from the Packetbeat event.
This change requires an update of the Packetbeat dashboards as they rely on count.

@monicasarbu monicasarbu force-pushed the remove_count_field_packetbeat branch from c05e0a7 to 482f511 Compare March 23, 2016 09:10
@ruflin
Copy link
Contributor

ruflin commented Mar 23, 2016

LGTM

@ruflin
Copy link
Contributor

ruflin commented Mar 23, 2016

@monicasarbu Seems like you missed some count checks in the packetbeat tests (see travis build).

@monicasarbu monicasarbu force-pushed the remove_count_field_packetbeat branch from 59f1642 to c242cdb Compare March 31, 2016 12:59
@andrewkroh
Copy link
Member

LGTM

After we complete the remove of count there should be final scrub of the repo to make sure we got them all. Like a find . -type f | xargs grep -n '"count"' sort of check.

@andrewkroh andrewkroh merged commit b826f4d into elastic:master Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Packetbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monicasarbu @ruflin @andrewkroh @kofemann