-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check goroutines in places related to recent found leaks #12106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our runtime metrics that get logged every 30s include a gauge for the number of goroutines? That would be helpful for identifying if a leak is introduced to a Beat.
I am moving the fix for the leak in |
Created PR for that #12135 |
b8c4367
to
1b42a6b
Compare
Failing tests caused by #12171 |
ca0e54f
to
34c627a
Compare
575e14c
to
02eeabb
Compare
@exekias @andrewkroh this would be ready for review, thanks! |
Test failure in Windows looks related, I'll look at this |
time.Sleep(10 * time.Millisecond) | ||
} | ||
profile := pprof.Lookup("goroutine") | ||
profile.WriteTo(os.Stdout, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. That's helpful.
Follows the strategy used in #10850 to check for goroutine leaks
on tests in some places related to the leaks investigated as part
of #9302.
Several things here:
goroutines dump on failure.
CloseOnSignal
andSubOutlet
tests (they detect the issues solved by Stop waiting for signals on closed outleters #11263)
by Fix goroutine leak on initialization failures of log input #12125 and Fix goroutine leak on non-explicit finalization of log inputs #12164)