Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic merge from master to 7.x branch #12224

Merged
merged 60 commits into from
May 22, 2019

Commits on May 7, 2019

  1. Use time.Duration directly in GetStartTimeEndTime function (elastic#1…

    …2033)
    
    * Remove convertPeriodToDuration and use duration directly in GetStartTimeEndTime
    
    * Pass period in time.Duration type
    kaiyan-sheng authored May 7, 2019
    Configuration menu
    Copy the full SHA
    82e7eec View commit details
    Browse the repository at this point in the history
  2. Fix memory leak in Filebeat pipeline acker (elastic#12063)

    * Fix memory leak in Filebeat pipeline acker
    
    Before this change acker goroutine was kept forever as processed events
    count was not correctly updated.
    
    Filebeat sends an empty event to update file states, this event is not
    published, but treated as dropped, without updating counters.
    
    This change makes sures that `a.events` count gets updated for dropped
    events also, so the acker gets closed after all ACKs happen.
    exekias authored May 7, 2019
    Configuration menu
    Copy the full SHA
    9653105 View commit details
    Browse the repository at this point in the history
  3. Add convert processor (elastic#11686)

    The `convert` processor converts a field in the event to a different type, such
    as converting a string to an integer. For a full description of the processor's
    capabilities see the included documentation.
    
    Closes elastic#8124
    andrewkroh authored May 7, 2019
    Configuration menu
    Copy the full SHA
    354cd4d View commit details
    Browse the repository at this point in the history
  4. Update docs.asciidoc (elastic#11852) (elastic#12045)

    * Update docs.asciidoc
    
    Added in a short note on a few of the other configurable variables.
    
    * Make update
    dedemorton authored May 7, 2019
    Configuration menu
    Copy the full SHA
    1fb3d63 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cea4efa View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. Don't generate autodiscover config when no port matches host hints (e…

    …lastic#12086)
    
    On metricbeat, when the host autodiscover hint is used, and it includes
    the port, one of the exposed ports has to match with the one in the
    hint. If not, no configuration should be generated. If it is generated,
    it will have empty hosts, what would lead to unexpected errors as the
    seen in elastic#8264.
    jsoriano authored May 8, 2019
    Configuration menu
    Copy the full SHA
    cc73643 View commit details
    Browse the repository at this point in the history
  2. Fix transptest testing (elastic#12091)

    Rewrite test for more clarity ensuring that the server and listeners are
    stopped before the test function returns (cause for the case condition).
    Each test has it's very own socks5 server now. Tests not requiring a
    proxy don't spin up one.
    Steffen Siering authored May 8, 2019
    Configuration menu
    Copy the full SHA
    2a8ee65 View commit details
    Browse the repository at this point in the history
  3. Refactor and add tests for template and ilm handling. (elastic#12065)

    Refactor and add more tests related to setting up template and ilm policy. Ensure template and ilm-policy is exported despite enabled=false setting.
    simitt authored May 8, 2019
    Configuration menu
    Copy the full SHA
    82edc23 View commit details
    Browse the repository at this point in the history
  4. [Auditbeat] Login: Fix re-read of utmp files (elastic#12028)

    The `login` dataset is not using the previous file offset when reading new entries in a utmp file. As a result, whenever a new login event occurs, all records are re-read.
    
    Also expands the documentation, moves test files to testdata/, and adds a test case that adds a utmp record to the test file and re-reads it to make sure this bug does not happen again.
    Christoph Wurm authored May 8, 2019
    Configuration menu
    Copy the full SHA
    683f4f7 View commit details
    Browse the repository at this point in the history
  5. [Metricbeat][postgresql] Update lib/pq to fix elastic#11393 (elastic#…

    …12094)
    
    This updates github.com/lib/pq to the latest version to fix a socket
    leak when SSL is not enabled on the PostgreSQL server.
    
    Fixes elastic#11393
    adriansr authored May 8, 2019
    Configuration menu
    Copy the full SHA
    622377a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c17586a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. Change image references to use block syntax not inline (elastic#11911)

    * Change image references to use block syntax not inline
    
    * Fix format for inline links
    dedemorton authored May 9, 2019
    Configuration menu
    Copy the full SHA
    043e60d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b39edc5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85757fd View commit details
    Browse the repository at this point in the history
  4. Revert printing template and policy name on export. (elastic#12067)

    Ensures behavior on running the `export` cmd does not change compared to last released version.
    simitt authored May 9, 2019
    Configuration menu
    Copy the full SHA
    5cf48bf View commit details
    Browse the repository at this point in the history
  5. [Filebeat] Add -expected files by default (elastic#12041)

    So far expected files in Filebeat tests were only generated and compared when a file exists. This changes to create a generated for all example logs. This will add a few more files to the repository but I think there the benefits outweight the costs as it means the modules are tested in more detail. Also minor changes will be detected easier.
    ruflin authored May 9, 2019
    Configuration menu
    Copy the full SHA
    ccbf05a View commit details
    Browse the repository at this point in the history
  6. Update vendored gosigar to 0.10.2 (elastic#12101)

    elastic#11924 duplicated some code from go-sysinfo that is affected by a memory leak (fixed in elastic#12100)
    
    In this case, only master is affected as the PR that introduced the leaky gosigar wasn't backported.
    adriansr authored May 9, 2019
    Configuration menu
    Copy the full SHA
    d4f3944 View commit details
    Browse the repository at this point in the history
  7. Fix various memory leaks under Windows (elastic#12100)

    A function in go-sysinfo used under Windows to split a command-line into arguments was leaking memory.
    
    This code was used in various places:
    
    add_process_metadata processor. (enabled by default in all Beats)
    Packetbeat's process monitor. (disabled by default).
    Auditbeat's system/process metricset.
    This PR updates vendored go-sysinfo to the most recent version, which fixes the leak.
    adriansr authored May 9, 2019
    Configuration menu
    Copy the full SHA
    a5b3f0a View commit details
    Browse the repository at this point in the history
  8. New processor extract_array (elastic#11761)

    This adds a new processor, extract_array, that allows accessing values
    inside arrays and copying them to target fields.
    adriansr authored May 9, 2019
    Configuration menu
    Copy the full SHA
    89f93e3 View commit details
    Browse the repository at this point in the history
  9. [Heartbeat] Remove not needed flags from setup command (elastic#11856)

    The setup command until now contained all the possible options from the other Beats. As Heartbeat does not ship anymore with dashboards, the --dashboards command is not needed anymore and is only confusing. I also removed all the other commands except `--ilm-policy` and `--template`. I'm not aware that `--pipelines` or `--machine-learning` would be used.
    
    Here the comparison between `./heartbeat setup -h` from before and after.
    
    Before:
    
    ```
    This command does initial setup of the environment:
    
     * Index mapping template in Elasticsearch to ensure fields are mapped.
     * Kibana dashboards (where available).
     * ML jobs (where available).
     * Ingest pipelines (where available).
     * ILM policy (for Elasticsearch 6.5 and newer).
    
    Usage:
      heartbeat setup [flags]
    
    Flags:
          --dashboards         Setup dashboards
      -h, --help               help for setup
          --ilm-policy         Setup ILM policy
          --machine-learning   Setup machine learning job configurations
          --pipelines          Setup Ingest pipelines
          --template           Setup index template
    ```
    
    After:
    
    ```
    This command does initial setup of the environment:
     * Index mapping template in Elasticsearch to ensure fields are mapped.
     * ILM Policy
    
    Usage:
      heartbeat setup [flags]
    
    Flags:
      -h, --help         help for setup
          --ilm-policy   Setup ILM policy
          --template     Setup index template
    ```
    
    In this PR I did not include a check for the config option `setup.dashboards` to make sure they are not there like apm-server does (https://github.com/elastic/apm-server/blob/2baefab778fdfe70c47bc2fb488677b2e43e4635/beater/beater.go#L60) as I don't think it's necessary.
    ruflin authored May 9, 2019
    Configuration menu
    Copy the full SHA
    e098e00 View commit details
    Browse the repository at this point in the history
  10. Skip Windows testing if magefile.go does not exist (elastic#12099)

    Changes the jenkins_ci.ps1 script to skip testing when magefile.go does not
    exist. This will allow us to add projects like x-pack/winlogbeat to the test
    matrix because not all branches have an x-pack/winlogbeat/magefile.go
    file.
    andrewkroh authored May 9, 2019
    Configuration menu
    Copy the full SHA
    cc05f62 View commit details
    Browse the repository at this point in the history
  11. Fix goroutine leak on initialization failures of log input (elastic#1…

    …2125)
    
    Outlets are created during log input initialization, and if it
    fails they were never freed. Handle this case.
    jsoriano authored May 9, 2019
    Configuration menu
    Copy the full SHA
    f2473d2 View commit details
    Browse the repository at this point in the history
  12. Document and improve permission checks when running socket metricset …

    …from Docker (elastic#12039)
    
    Update instructions for system/socket metricset on Docker. And base
    permission checks on capabilities rather than on the effective uid.
    Running a process as root doesn't mean that it has all privileges,
    specially when run as container.
    jsoriano authored May 9, 2019
    Configuration menu
    Copy the full SHA
    2cbdc9a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bbf4156 View commit details
    Browse the repository at this point in the history
  14. Change type from scaled_float to long and add format (elastic#11982)

    * Change type from scaled_float to long and add format
    kaiyan-sheng authored May 9, 2019
    Configuration menu
    Copy the full SHA
    1b2613e View commit details
    Browse the repository at this point in the history
  15. [libbeat] Add unit tests for libbeat's client proxy settings (elastic…

    …#12044)
    
    These tests set up server listeners and create libbeat clients with varying proxy settings, and verify that the clients ping the correct target URL.
    
    This is a preparation for elastic#11713, since most of the logic (and work) is in testing the proxy settings; the much simpler PR adding the proxy-disable flag will be a followup to this one, to keep the functional changes isolated in case of rollbacks etc.
    faec authored May 9, 2019
    Configuration menu
    Copy the full SHA
    88a2604 View commit details
    Browse the repository at this point in the history
  16. [Metricbeat](Etcd-Leader)Followers wont report leader metrics (elasti…

    …c#12004)
    
    * manage leader metricset so that followers don't report errors nor events
    * add debug message when skipping leader events from non leader members
    odacremolbap authored May 9, 2019
    Configuration menu
    Copy the full SHA
    cd5c3ad View commit details
    Browse the repository at this point in the history
  17. Add package libbeat/common/cleanup (elastic#12134)

    * Add package libbeat/common/cleanup
    
    The cleanup package adds helpers for deferred optional cleanup on
    errors.
    
    For example:
    
    ```
    ok := False
    defer cleanup.IfNot(&ok, func() { ... })
    
    // continue initialization
    
    ok = True
    return // some value
    ```
    
    * Add changelog entry
    Steffen Siering authored May 9, 2019
    Configuration menu
    Copy the full SHA
    44a87a8 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    0460448 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    6f8ddd6 View commit details
    Browse the repository at this point in the history
  20. Sysmon and Security "modules" for Winlogbeat (elastic#11651)

    Add pipelines for the Security and Sysmon event logs
    
    The Security processor handles just three events to start with - 4624, 4625, and 4648.
    These are event.category=authentication events.
    
    The Sysmon processor handles all event IDs found in the sysmon manifest (sysmon -s).
    It moves the event_data fields that are in ECS and does some type conversions.
    andrewkroh authored May 9, 2019
    Configuration menu
    Copy the full SHA
    cf5de0a View commit details
    Browse the repository at this point in the history
  21. [Auditbeat] Process: Add hash of executable (elastic#11722)

    Adds the hash(es) of the process executable to `process.hash.*`. The default is to add SHA-1 only as `process.hash.sha1`.
    Christoph Wurm authored May 9, 2019
    Configuration menu
    Copy the full SHA
    c9ffceb View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8bbbab0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. [Filebeat] Introduce UTC as default timezone for modules tests (elast…

    …ic#12120)
    
    Currently all our modules have convert_timezone disable by default. The reason in 6.x for this was probably that 6.0 did not support convert_timezone and we did not want to introduce a breaking changes. New modules should have convert_timezone enabled by default.
    
    If a module has convert_timezone enabled by default the tests will fail as it takes the timezone of the local computer. To circumvent this, this PR sets the timezone of the tests to UTC so the same time zone is always used.
    
    No generated files were changed in this PR as all modules have convert_timezone off by default. But it will affect elastic#12079 and elastic#12032
    ruflin authored May 10, 2019
    Configuration menu
    Copy the full SHA
    65d652d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4a427d View commit details
    Browse the repository at this point in the history
  3. Add minimal ES template functionality. (elastic#12103)

    When loading a template without fields, create a minimal template only applying given configuration, without any default values for mappings and settings. This allows to create additional templates only defining specific values.
    simitt authored May 10, 2019
    Configuration menu
    Copy the full SHA
    9ece0af View commit details
    Browse the repository at this point in the history
  4. Refactor logging in pgsql module (elastic#12151)

    Guard debug logging statements with "isDebug" checks. And switch the module over to using named loggers.
    
    Fixes elastic#12150
    andrewkroh authored May 10, 2019
    Configuration menu
    Copy the full SHA
    056d921 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    59378cd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed55279 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. [Filebeat] module for palo_alto (pan-os) logs (elastic#11999)

    This is a module for Palo Alto Networks PAN-OS logs received via Syslog.
    
    It has been tested with logs for PAN-OS version 7.1 to 9.0. However, it is expected to work with earlier versions as the log format is compatible.
    adriansr authored May 11, 2019
    Configuration menu
    Copy the full SHA
    f69dadb View commit details
    Browse the repository at this point in the history
  2. [cmd setup] Add and deprecate setup cmds for index handling (elastic#…

    …12132)
    
    Deprecate `setup --template` and `setup --ilm` in favour of newly introduced `setup --index-management` command.
    Fix bug in template and write alias creation order to ensure creating properly managed indices. 
    
    implements elastic#12095
    
    Co-authored-by: steffen.siering@elastic.co
    simitt authored May 11, 2019
    Configuration menu
    Copy the full SHA
    d5b6a2b View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. Zdd zfs beat (elastic#12136)

    Querying ZFS Storage and Pool Status
    maireanu authored and ruflin committed May 13, 2019
    Configuration menu
    Copy the full SHA
    6f87f3c View commit details
    Browse the repository at this point in the history
  2. [metricbeat] Expand metricbeat dev guide for testing (elastic#12105)

    * update dev guide to add examples and expand testing
    fearful-symmetry authored May 13, 2019
    Configuration menu
    Copy the full SHA
    d9668d3 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Bugfix set template.order to 1 by default. (elastic#12160)

    To ensure default order is not changed to 0, set it to 1 in default config.
    simitt authored May 14, 2019
    Configuration menu
    Copy the full SHA
    3003cfb View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. [Auditbeat] Fix issues with multiple calls to rpmReadConfigFiles (ela…

    …stic#12168)
    
    This patch fixes two issues in Auditbeat's system/package on RPM
    distros:
    
    - Multiple calls to rpmReadConfigFiles lead to a crash (segmentation
      fault). It is necessary to call rpmFreeRpmrc after each call to
      rpmReadConfigFiles.
    
      See [1] for a similar issue.
    
    - In addition, it is also necessary to call rpmFreeMacros (when
      available) to avoid leaking memory after each
      rpmReadConfigFiles call.
    
    1: https://lists.fedorahosted.org/pipermail/anaconda-patches/2015-February/015826.html
    
    Fixes elastic#12147
    adriansr authored May 15, 2019
    Configuration menu
    Copy the full SHA
    a1a7d7e View commit details
    Browse the repository at this point in the history
  2. [Filebeat] Palo_alto module improvements (elastic#12182)

    This PR adds some missing features to the recently merged palo_alto module:
    
    Dashboards (One for traffic logs, one for threats).
    Sets network.type to either ipv4 or ipv6.
    Renames palo_alto.pan_os.threat_file_or_url to palo_alto.pan_os.threat.resource.
    Splits palo_alto.pan_os.threat_id into palo_alto.pan_os.threat.id and palo_alto.pan_os.threat.name.
    adriansr authored May 15, 2019
    Configuration menu
    Copy the full SHA
    3b0e1c7 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Configuration menu
    Copy the full SHA
    56764fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f549cec View commit details
    Browse the repository at this point in the history
  3. [Filebeat] Add RabbitMQ module (elastic#12032)

    * Parses single and multiline messages from [RabbitMQ's unified log file](https://www.rabbitmq.com/logging.html#log-file-location)
    * `var.paths` uses the `RABBITMQ_LOGS` env variable if present
    * `var.convert_timezone` (enabled by default since the [timestamps are localtime by default](https://github.com/erlang-lager/lager#universal-time)) 
    * No dashboard
    * Tested with
      ```
      ~/go/src/github.com/elastic/beats/x-pack/filebeat [master @ 092a3f5] ✓ ‣ MODULES_PATH=./module GENERATE=1 INTEGRATION_TESTS=1 TESTING_FILEBEAT_MODULES=rabbitmq nosetests tests/system/test_xpack_modules.py -v
      test_fileset_file_0_rabbitmq (test_xpack_modules.XPackTest) ... ok
    
      ----------------------------------------------------------------------
      Ran 1 test in 3.320s
    
      OK
      ```
    John Schulz authored May 16, 2019
    Configuration menu
    Copy the full SHA
    b5c92a7 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. [metricbeat] Add linux sockstat data to socket_summary metricset (ela…

    …stic#12050)
    
    * add sockstat data to socket_summary
    fearful-symmetry authored May 17, 2019
    Configuration menu
    Copy the full SHA
    88660dc View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. Fix goroutine leak on non-explicit finalization of log inputs (elasti…

    …c#12164)
    
    If log inputs were finished because their context, or one of their
    ouleters have been finished, then it wasn't stopping its harvesters,
    leaking resources.
    jsoriano authored May 20, 2019
    Configuration menu
    Copy the full SHA
    6914806 View commit details
    Browse the repository at this point in the history
  2. [Metricbeat] CoreDNS module: Add Kibana Dashboard (elastic#11619)

    * [Metricbeat] CoreDNS module: Add Kibana Dashboard
    
    Fixes elastic#10432.
    ioandr authored and Pablo Mercado committed May 20, 2019
    Configuration menu
    Copy the full SHA
    0495f6c View commit details
    Browse the repository at this point in the history
  3. [Libbeat][Metricbeat]Add IgnoreAllErrors to schema.Conv object (elast…

    …ic#12089)
    
    * schema conv option for ignore all errors
    
    Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
    Pablo Mercado and jsoriano authored May 20, 2019
    Configuration menu
    Copy the full SHA
    9c848a9 View commit details
    Browse the repository at this point in the history
  4. Add container input, deprecate docker in favor of it (elastic#12162)

    Add `container` input, deprecate `docker` in favor of it
    
    This change adds a new container input for better support of CRI based
    scenarios.
    
    `docker` input was acting as a catch all input for all container related
    cases, but its config options were very opinionated towards Docker, with
    some issues:
    
     * `containers.ids` setting was good to abstract logs path, but we have
     seen many cases were logs are not under default location, or follow a
     different path pattern (ie CRI logs).
     * `containers.*` settings have shown counter intuitive for many users,
     in many cases we have seen people writing `container.*` instead, ending
     up in a config error.
     * Some existing settings (`combine_partials`, `cri.parse_flags`) were
     introduced as a way to offer a backwards compatible upgrades, but it
     doesn't really make sense to disable them, as they handle actual
     format behaviors.
    
    This new `container` input offers the same wrapper to read log files
    from containers with the following changes:
    
     * It exposes `paths` as the `log` input, instead of `containers.ids`
     and `containers.path`.
     * `parse_flags` and `combine_partials` are hardcoded, as there is no
     good reason to disable them.
     * `stream` selector is still available, under root settings.
     * It allows to select the log format (also atodetect it), giving room
     for future format changes. `format` can be `auto` (default), `docker`
        and `CRI`.
    
    Example configurations:
    
    Get Docker logs:
    
    ```
    filebeat.inputs:
    - type: container
      paths:
        - /var/lib/docker/containers/*/*.log
    ```
    
    Get Kubernetes logs:
    
    ```
    filebeat.inputs:
    - type: container
      paths:
        - /var/log/pods/*/*/*.log
        # this could also be used:
        #- /var/log/containers/*.log
    ```
    
    Previous `docker` input is deprecated in favor of this, to be removed in 8.0
    Carlos Pérez-Aradros Herce authored May 20, 2019
    Configuration menu
    Copy the full SHA
    313e6d1 View commit details
    Browse the repository at this point in the history
  5. [Auditbeat] Fix formatting of config files on macOS and Windows (elas…

    …tic#12148)
    
    Fixes formatting of auditbeat.yml and auditbeat.reference.yml across platforms.
    Christoph Wurm authored May 20, 2019
    Configuration menu
    Copy the full SHA
    d3ef979 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Configuration menu
    Copy the full SHA
    eca4b19 View commit details
    Browse the repository at this point in the history
  2. Set beat ID in registries after loading meta file (elastic#12180)

    * Reset beat ID in registries in case loaded from meta file
    
    * Set, not reset
    
    * Adding CHANGELOG entry
    ycombinator authored May 21, 2019
    Configuration menu
    Copy the full SHA
    da783fe View commit details
    Browse the repository at this point in the history
  3. [Filebeat] Move dashboards from 8 to 7 directory (elastic#12217)

    The CoreDNS and Envoyproxy dashboard were in the 8 instead of 7 directory. This PR fixes this.
    ruflin authored May 21, 2019
    Configuration menu
    Copy the full SHA
    2ce9c8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4bc667 View commit details
    Browse the repository at this point in the history
  5. adjust doc

    ph committed May 21, 2019
    Configuration menu
    Copy the full SHA
    2c9a5aa View commit details
    Browse the repository at this point in the history