Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host.os.codename to fields.yml #12261

Merged
merged 3 commits into from
May 24, 2019
Merged

Add host.os.codename to fields.yml #12261

merged 3 commits into from
May 24, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented May 23, 2019

The add_host_metadata processor adds host.os.codename when available (e.g. on Debian):

beats/libbeat/metric/system/host/host.go

Lines 50 to 52 in 874e01f

if info.OS.Codename != "" {
data.Put("host.os.codename", info.OS.Codename)
}

This adds the missing field definition for it to the processor's fields.yml.

@cwurm cwurm added the review label May 23, 2019
@cwurm cwurm requested review from a team as code owners May 23, 2019 23:01
@cwurm cwurm removed the request for review from a team May 23, 2019 23:01
@cwurm cwurm mentioned this pull request May 23, 2019
Merged
ruflin
ruflin approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this need backports?

@cwurm cwurm merged commit 08ccdd7 into elastic:master May 24, 2019
@cwurm cwurm deleted the host_metadata_os_codename branch May 24, 2019 16:09
@cwurm
Copy link
Contributor Author

cwurm commented May 24, 2019

Will this need backports?

I'll do 7.2 only, to get #12259 in.

cwurm pushed a commit to cwurm/beats that referenced this pull request May 24, 2019
Add host.os.codename to fields.yml (elastic#12261)
867c359 
The `add_host_metadata` processor adds `host.os.codename` when available (e.g. on Debian). This adds the missing field definition for it to the processor's `fields.yml`.

(cherry picked from commit 08ccdd7)
@cwurm cwurm mentioned this pull request May 24, 2019
Merged
@cwurm cwurm added the v7.2.0 label May 24, 2019
cwurm pushed a commit that referenced this pull request May 28, 2019
Add host.os.codename to fields.yml (#12261) (#12282)
4ad71b2 
The `add_host_metadata` processor adds `host.os.codename` when available (e.g. on Debian). This adds the missing field definition for it to the processor's `fields.yml`.

(cherry picked from commit 08ccdd7)
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
Add host.os.codename to fields.yml (elastic#12261)
f195bcd 
The `add_host_metadata` processor adds `host.os.codename` when available (e.g. on Debian). This adds the missing field definition for it to the processor's `fields.yml`.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Add host.os.codename to fields.yml (elastic#12261) (elastic#12282)
37f1b9d 
The `add_host_metadata` processor adds `host.os.codename` when available (e.g. on Debian). This adds the missing field definition for it to the processor's `fields.yml`.

(cherry picked from commit 133c43e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
review v7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwurm @ruflin