-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import ECS 1.0.1 #12284
Merged
Merged
Import ECS 1.0.1 #12284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
added
ecs
needs_backport
PR is waiting to be backported to other branches.
v7.2.0
labels
May 24, 2019
cwurm
reviewed
May 24, 2019
Pushed the fix & updated fields.go. This should be good now. |
cwurm
approved these changes
May 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests go green or unrelated.
@webmat Tests are green, feel free to merge. :) |
Just noticing: Can you please add a changelog entry. |
Merged
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 28, 2019
(cherry picked from commit 31a4da7)
cwurm
pushed a commit
that referenced
this pull request
Jun 5, 2019
Updates vendor dependency to ECS 1.0.1. Field definitions were already imported in #12284. Removes `ecs.version` from Filebeat golden files.
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this pull request
Jun 12, 2019
Updates vendor dependency to ECS 1.0.1. Field definitions were already imported in elastic#12284. Removes `ecs.version` from Filebeat golden files.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch release of ECS, as it only contains minor fixes, mostly field formatting, and examples for a few fields. No new fields in this release.
The killer feature of ECS 1.0.1 is elastic/ecs#454. This change will make pivoting around numeric values such as port numbers & PIDs much more streamlined, as it will prevent Kibana from adding thousands separators.
I'm hoping we can backport this to 7.2, as I think it fits really well with the introduction of the SIEM app.