Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ECS 1.0.1 #12284

Merged
merged 5 commits into from
May 27, 2019
Merged

Import ECS 1.0.1 #12284

merged 5 commits into from
May 27, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented May 24, 2019

This is a patch release of ECS, as it only contains minor fixes, mostly field formatting, and examples for a few fields. No new fields in this release.

The killer feature of ECS 1.0.1 is elastic/ecs#454. This change will make pivoting around numeric values such as port numbers & PIDs much more streamlined, as it will prevent Kibana from adding thousands separators.

I'm hoping we can backport this to 7.2, as I think it fits really well with the introduction of the SIEM app.

@webmat webmat requested review from a team as code owners May 24, 2019 18:37
@webmat webmat self-assigned this May 24, 2019
@webmat webmat added ecs needs_backport PR is waiting to be backported to other branches. v7.2.0 labels May 24, 2019
@webmat webmat requested review from cwurm and a team May 24, 2019 18:38
libbeat/_meta/fields.ecs.yml Outdated Show resolved Hide resolved
@webmat
Copy link
Contributor Author

webmat commented May 24, 2019

Pushed the fix & updated fields.go. This should be good now.

Copy link
Contributor

@cwurm cwurm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests go green or unrelated.

@webmat
Copy link
Contributor Author

webmat commented May 24, 2019

The previous run was pretty green (jenkins, travis). Only failure seemed unrelated.

If you're good to merge this now, I think it's safe to do so. However I don't play in this repo often, so not sure what the customs are :-)

@cwurm
Copy link
Contributor

cwurm commented May 24, 2019

@webmat Tests are green, feel free to merge. :)

@cwurm
Copy link
Contributor

cwurm commented May 25, 2019

Just noticing: Can you please add a changelog entry.

@webmat webmat merged commit 31a4da7 into elastic:master May 27, 2019
webmat pushed a commit to webmat/beats that referenced this pull request May 27, 2019
@webmat
Copy link
Contributor Author

webmat commented May 27, 2019

@cwurm Changelog added, thanks for noticing :-)

Backport PR is now open: #12299

@cwurm cwurm mentioned this pull request May 28, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request May 28, 2019

(cherry picked from commit 31a4da7)
cwurm pushed a commit that referenced this pull request Jun 5, 2019
Updates vendor dependency to ECS 1.0.1. Field definitions were already imported in #12284. Removes `ecs.version` from Filebeat golden files.
andrewvc pushed a commit to andrewvc/beats that referenced this pull request Jun 12, 2019
Updates vendor dependency to ECS 1.0.1. Field definitions were already imported in elastic#12284. Removes `ecs.version` from Filebeat golden files.
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecs needs_backport PR is waiting to be backported to other branches. v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants