[Auditbeat] Cherry-pick #12289 to 7.2: Package: Auto-detect package directories #12323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `system/package` dataset to select the package manager based on which package directories exist: `/var/lib/dpkg`, `/var/lib/rpm`, or `/usr/local/Cellar`. If we find no directories, we log a warning once and continue checking. We do not abort Auditbeat's launch. (cherry picked from commit afbe070)
cwurm
changed the title
|
Pinging @elastic/secops |
adriansr
approved these changes
May 29, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ckage directories (elastic#12323) Changes the `system/package` dataset to select the package manager based on which package directories exist: `/var/lib/dpkg`, `/var/lib/rpm`, or `/usr/local/Cellar`. If we find no directories, we log a warning once and continue checking. We do not abort Auditbeat's launch. (cherry picked from commit 33d5d1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12289 to 7.2 branch. Original message:
Users have recently struggled with using Auditbeat on distros the
system/packagedataset does not recognize. When this happens, Auditbeat aborts the start with a not very helpful error message.This PR fixes this by changing the behavior:
/var/lib/dpkg,/var/lib/rpm, or/usr/local/Cellar. In the future, we could make these configurable.Possible future improvements:
package.type(naming tbd) to distinguish between rpm, deb, and homebrew packages.This is a bigger change, but I'd want to backport it as a bugfix since the current behavior is causing frustration to users. The system module is still in beta, giving us more freedom in what we backport.