Only log error (don't also index it) if xpack is enabled. #12353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
Metricbeat
|
Pinging @elastic/stack-monitoring |
cachedout
approved these changes
May 31, 2019
ycombinator
force-pushed
the
mb-kb-only-log-error-xp-71
branch
from
52d471a to
c3024eb
Compare
ycombinator
added a commit
that referenced
this pull request
Jun 3, 2019
…) (#12379) * Only log error (don't also index it) if xpack is enabled. * Adding CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
xpack.enabled: trueis set on a stack module, the expectation is that the user won't see anymetricbeat-*indices. Instead users expect to see.monitoring-*indices.However, metricbeat indexes errors into
metricbeat-*indices. So in an error situation whenxpack.enabled: trueis set, we don't want to index errors but just log them. That's what this PR fixes for thekibana/statsmetricset.Equivalent of #12265 but for 7.1 (see #12265 (comment) for rationale).