Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Debug logging from fail_on_error logic #12496

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Decouple Debug logging from fail_on_error logic #12496

merged 1 commit into from
Jun 14, 2019

Conversation

AndyHunt66
Copy link
Contributor

@AndyHunt66 AndyHunt66 commented Jun 11, 2019

When using the rename, copy_fields or truncate_fields processors, and specifying multiple fields to be processed

if the processor fails on one of the fields (usually because a field is not present), a Debug log message will only be thrown if fail_on_error is true .
Logging of the error should be independent of the fail_on_error flag.


Ref #12451

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvch Could you also have a look?

@ruflin
Copy link
Contributor

ruflin commented Jun 11, 2019

jenkins, test this

Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ruflin
Copy link
Contributor

ruflin commented Jun 14, 2019

jenkins, test this

@kvch
Copy link
Contributor

kvch commented Jun 14, 2019

Failing tests are unrelated.

@kvch kvch merged commit 326da8a into elastic:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants