Exclude modules with init() in tests from includes lists #12650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
reviewed
Jun 24, 2019
| @@ -33,7 +33,6 @@ import ( | |||
| _ "github.com/elastic/beats/packetbeat/protos/nfs" | |||
| _ "github.com/elastic/beats/packetbeat/protos/pgsql" | |||
| _ "github.com/elastic/beats/packetbeat/protos/redis" | |||
| _ "github.com/elastic/beats/packetbeat/protos/tcp" | |||
There was a problem hiding this comment.
I guess this was doing nothing?
There was a problem hiding this comment.
Correct, it has an init on its tests.
exekias
approved these changes
Jun 24, 2019
andrewkroh
reviewed
Jun 24, 2019
| if err != nil { | ||
| log.Fatal("Failed checking for .go files in package dir: %v", err) | ||
| } | ||
| if len(goFiles) == 0 { |
There was a problem hiding this comment.
I think this was used as a sanity check with the assumption that anything using this code should find at least one thing to import. Maybe we should add this check after the for loop completes?
There was a problem hiding this comment.
I removed this check because at the end if there are no go files then foundInitMethod is never going to be true.
|
jenkins, test this again please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool that collects modules for the includes lists checks only
include packages that have an init method, but it can also
include packages whose inits methods are defined only in
tests. Exclude these packages from the list.
This is required to do go tests in modules without code as
filebeat modules or metricbeat light modules (#12270).