-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add ability to collect client-provided name for rabbitmq connections #12852
[Metricbeat] Add ability to collect client-provided name for rabbitmq connections #12852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a single comment. Tell me WDYT :)
"frame_max": c.Int("frame_max"), | ||
"type": c.Str("type"), | ||
"name": c.Str("name"), | ||
"client_provided_name": c.Str("client_properties.connection_name"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to call this client_provided.name
or event something like client.name
. The reason is that probably we can enrich this with more fields in a near future (or maybe not) an, if so, we probably won't like to have
client_provided_name
client_provided_tag
client_provided_label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take into account that this is a name for the connection, so +1 to something like client_provided.name
, but don't use client.name
, it would look like the name of the client.
We may also keep the original client_properties
naming, so if there are more properties in the future we store them as:
rabbitmq.connection.client_properties.name
rabbitmq.connection.client_properties.tag
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, ok on my side. for anyone testing integrations:
|
@odacremolbap Thanks for pointing that out. I need to update the PR description with how to test it. |
This PR is to add collection for Client-provided names in rabbitmq connections.
RabbitMQ 3.6.5 added the facility for the connecting client to report a friendly name string value to identify a connection for management purposes. This is strictly an identifier and, as it is client-reported, it cannot be relied upon for anything other than weak identification of connections.
closes #12851
How to test it:
Bring up rabbitmq by running:
rabbitmq-server
How to send and receive messgaes: https://www.rabbitmq.com/tutorials/tutorial-one-go.html
How to start a connection with client-provided name: