Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat]kubernetes cronjob through kube-state-metrics #13001

Merged
merged 14 commits into from
Aug 8, 2019
Merged

[metricbeat]kubernetes cronjob through kube-state-metrics #13001

merged 14 commits into from
Aug 8, 2019

Conversation

odacremolbap
Copy link
Contributor

@odacremolbap odacremolbap commented Jul 22, 2019 •
edited
Loading

Add kubernetes cronjob metrics using kube-state-metrics

Cronjob metrics as informed by kube-state-metrics
Pod information is not retrieved using these metrics.
Enricher is not used

@odacremolbap odacremolbap requested review from a team as code owners July 22, 2019 10:52
@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team containers Related to containers use case in progress Pull request is currently in progress. Metricbeat Metricbeat labels Jul 22, 2019
@odacremolbap odacremolbap self-assigned this Jul 22, 2019
@odacremolbap
Copy link
Contributor Author

jenkins test this

@odacremolbap odacremolbap added review and removed in progress Pull request is currently in progress. labels Jul 29, 2019
sayden
sayden approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks awesome! Well done! I left some comment

metricbeat/module/kubernetes/state_cronjob/README.md Outdated Show resolved Hide resolved
metricbeat/module/kubernetes/state_cronjob/_meta/fields.yml Outdated Show resolved Hide resolved
metricbeat/module/kubernetes/state_cronjob/_meta/fields.yml Outdated Show resolved Hide resolved
jsoriano
jsoriano reviewed Aug 5, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, just one thing.

metricbeat/module/kubernetes/state_cronjob/state_cronjob.go Outdated Show resolved Hide resolved
@odacremolbap odacremolbap requested a review from sayden August 6, 2019 07:51
@sayden
Copy link
Contributor

sayden commented Aug 6, 2019

After the change of namespace mentioned by @jsoriano everything looks good :)

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@jsoriano
Copy link
Member

jsoriano commented Aug 7, 2019

Failures in CI doesn't seem related, I think this is good to go.

@odacremolbap
Copy link
Contributor Author

jenkins, test this

1 similar comment
@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap odacremolbap merged commit d84f4bb into elastic:master Aug 8, 2019
@odacremolbap odacremolbap deleted the task/kube-state-metrics-cronjobs branch August 8, 2019 06:53
@sorantis
Copy link
Contributor

sorantis commented Aug 8, 2019 •
edited
Loading

Hey @odacremolbap , nice work on the PR! Any plans on adding a dashboard for this metricset?

@odacremolbap
Copy link
Contributor Author

@sorantis

there is no kubernetes dashboard for the kube-state-metrics objects, I think they are somehow included in the kibana > infrastructure > kubernetes, but I haven't been exposed to it.
Don't know who to reach.

@andresrc andresrc added test-plan Add this PR to be manual test plan needs testing notes and removed [zube]: Done labels Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@jsoriano jsoriano jsoriano approved these changes

@sayden sayden Awaiting requested review from sayden

Assignees

@odacremolbap odacremolbap

Labels
containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Cronjob support
6 participants
@odacremolbap @sayden @jsoriano @sorantis @houndci-bot @andresrc