Add support for RFC3339 time zone offsets in JSON output #13227
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| return MakeUTCOrLocalTimestampEncoder(false) | ||
| } | ||
|
|
||
| func MakeUTCOrLocalTimestampEncoder(localTime bool) func(*time.Time, structform.ExtVisitor) error { |
There was a problem hiding this comment.
exported function MakeUTCOrLocalTimestampEncoder should have comment or be unexported
| return MakeUTCOrLocalTimestampEncoder(false) | ||
| } | ||
|
|
||
| func MakeUTCOrLocalTimestampEncoder(localTime bool) func(*time.Time, structform.ExtVisitor) error { |
There was a problem hiding this comment.
exported function MakeUTCOrLocalTimestampEncoder should have comment or be unexported
| return MakeUTCOrLocalTimestampEncoder(false) | ||
| } | ||
|
|
||
| func MakeUTCOrLocalTimestampEncoder(localTime bool) func(*time.Time, structform.ExtVisitor) error { |
There was a problem hiding this comment.
exported function MakeUTCOrLocalTimestampEncoder should have comment or be unexported
|
Thanks! Can you add the function comments above, and run |
|
Will do
…On Tue, Aug 13, 2019, 12:15 PM Fae Charlton ***@***.***> wrote:
Thanks! Can you add the function comments above, and run make fmt update?
I think the latter should format your code and unstick the CI build.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13227?email_source=notifications&email_token=AACDH5SMBBKBHXY4GQ3KRFDQEMB6RA5CNFSM4ILGHXQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GV6NI#issuecomment-520970037>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACDH5UAP7AWF3223QUJGR3QEMB6RANCNFSM4ILGHXQA>
.
|
|
jenkins, test this |
|
Actually one more thing before merge: can you update the changelog? Just add a one-line summary in |
I saw the TODO in code as we have a company standard to log in local timezone, so wanted to add support for local timezone as the JSON output