-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functionbeat] fix cloudwatch logs timestamp to use logRecord timestamp… #13291
Conversation
… instead of record processing timestamp
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
When I run If I run it from the root of the repo: I see I'm happy to make any changes needed but could use some guidance. Thank you! |
For your question about mage, maybe run |
@kaiyan-sheng Thank you! I was able to just run |
Should I not be using master branch in my forked source branch? |
@sbasgall Fixes look good to me, can we add a simple test in https://github.com/elastic/beats/blob/master/x-pack/functionbeat/provider/aws/aws/transformer/transformer_test.go to make sure we never have a regression on it. |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thank you all so much, Last week we were in the final stages of our migration to Elastic and I was unable to find any quiet time to write the tests. |
… instead of record processing timestamp
The suggested TODO code passes the Cloudwatch timestamp as seconds. The Cloudwatch field value is milliseconds. Pass it as nanoseconds times 1000000.
Closes: #12412