[Metricbeat] Fix silent failures in kafka and prometheus #13353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
requested changes
Aug 27, 2019
kaiyan-sheng
added
Team:Integrations
jsoriano
reviewed
Aug 27, 2019
| } | ||
|
|
||
| block := resp.GetBlock(topic, partition) | ||
| if len(block.Offsets) == 0 { | ||
| return -1, nil | ||
| return -1, errors.Wrap(block.Err, "block offsets is empty") |
There was a problem hiding this comment.
I am worried this can change some behaviour. But I don't think so, at the end an error was reported by the metricset on this case.
There was a problem hiding this comment.
Yeah previously it will return nil but offOK returned from queryOffsetRange will still be false so it goes into the same if statement.
Yeah good point! |
jsoriano
approved these changes
Aug 27, 2019
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 28, 2019
* Fix silent failures in kafka and prometheus * Change error log to warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two tiny fixes for silent failures due to missing proper return error. One is in kafka module, when
GetAvailableOffsetsfailed, the error is not reported. The other place is in prometheus module, it silently fails if metric name is incorrect (#13252).