-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in Redis key metricset #13426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics.
jsoriano
added
bug
module
Metricbeat
Metricbeat
needs_backport
PR is waiting to be backported to other branches.
Team:Integrations
Label for the Integrations team
v7.4.0
v7.2.2
v7.3.2
v6.8.4
labels
Aug 29, 2019
kaiyan-sheng
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jsoriano
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Aug 30, 2019
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 99ded55)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 99ded55)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 99ded55)
This was referenced Aug 30, 2019
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 99ded55)
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 318a041)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 318a041)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object, this nil object should be ignored, if passed to `eventMapping` it panics. (cherry picked from commit 318a041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Metricbeat
Metricbeat
module
Team:Integrations
Label for the Integrations team
v6.8.4
v7.2.2
v7.3.2
v7.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a key is removed during a fetch,
FetchKeyInfo
returns a nil object,this nil object should be ignored, if passed to
eventMapping
itpanics.
Reported in https://discuss.elastic.co/t/panic-in-redis-module/197253