Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversions of events with module fields #13433

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Fix conversions of events with module fields #13433

merged 1 commit into from
Aug 30, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 30, 2019 •
edited by zube bot
Loading

Metricsets that use special fields like ModuleDataKey cannot be
directly used as metricset fields of mb.Event, they need to be
converted using something like the mb.TransformMapStrToEvent()
helper.

Fix #13432

@jsoriano
Fix conversions of events with module fields
41ee469 
Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432
@jsoriano jsoriano added bug module review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Integrations Label for the Integrations team v7.4.0 v7.2.2 v7.3.2 labels Aug 30, 2019
@jsoriano jsoriano requested a review from a team as a code owner August 30, 2019 09:45
@jsoriano jsoriano self-assigned this Aug 30, 2019
@jsoriano jsoriano added the test-plan Add this PR to be manual test plan label Aug 30, 2019
ChrsMark
ChrsMark approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsoriano
Copy link
Member Author

Failing test in CI is not related.

@jsoriano jsoriano merged commit 310a96e into elastic:master Aug 30, 2019
@jsoriano jsoriano deleted the fix-metricbeat-module-fields-kubernetes branch August 30, 2019 12:48
@ChrsMark ChrsMark mentioned this pull request Aug 30, 2019
Merged
@jsoriano jsoriano mentioned this pull request Aug 30, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
@jsoriano
Fix conversions of events with module fields (elastic#13433)
6c5a8f5 
Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432

(cherry picked from commit 310a96e)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Aug 30, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
@jsoriano
Fix conversions of events with module fields (elastic#13433)
771176e 
Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432

(cherry picked from commit 310a96e)
@jsoriano jsoriano mentioned this pull request Aug 30, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
@jsoriano
Fix conversions of events with module fields (elastic#13433)
121edbf 
Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432

(cherry picked from commit 310a96e)
@jsoriano jsoriano mentioned this pull request Aug 30, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
@jsoriano
Add missing changelog for elastic#13433
d0e7737
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
@jsoriano
Add missing changelog for elastic#13433
eff6bde
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
@jsoriano
Add missing changelog for elastic#13433
95c05b2
@jsoriano jsoriano mentioned this pull request Aug 30, 2019
Merged
jsoriano added a commit that referenced this pull request Aug 30, 2019
@jsoriano
Add missing changelog for #13433 (#13443)
4c8248a
jsoriano added a commit that referenced this pull request Aug 31, 2019
@jsoriano
Cherry-pick #13433 to 7.4: Fix conversions of events with module fiel…
db6da10 
…ds (#13440)

Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix #13432

(cherry picked from commit 310a96e)
jsoriano added a commit that referenced this pull request Sep 3, 2019
@jsoriano
Cherry-pick #13433 to 7.3: Fix conversions of events with module fiel…
0959879 
…ds (#13441)

Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix #13432

(cherry picked from commit 310a96e)
jsoriano added a commit that referenced this pull request Sep 3, 2019
@jsoriano
Cherry-pick #13433 to 7.2: Fix conversions of events with module fiel…
45018e4 
…ds (#13442)

Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix #13432

(cherry picked from commit 310a96e)
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 8, 2019
@jsoriano
Fix conversion of events with module fields
0d5a931 
Apply elastic#13433 also to the kubernetes `state_node` metricset.

Fix elastic#13432
@jsoriano jsoriano mentioned this pull request Sep 8, 2019
Merged
jsoriano added a commit that referenced this pull request Sep 9, 2019
@jsoriano
Fix conversion of events with module fields (#13544)
b2ead08 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in #13433 with
other metricsets.

Fix #13432
@jsoriano jsoriano mentioned this pull request Sep 9, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 9, 2019
@jsoriano
Fix conversion of events with module fields (elastic#13544)
4088ef6 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in elastic#13433 with
other metricsets.

Fix elastic#13432

(cherry picked from commit b2ead08)
@jsoriano jsoriano mentioned this pull request Sep 9, 2019
Merged
@jsoriano jsoriano mentioned this pull request Sep 9, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 9, 2019
@jsoriano
Fix conversion of events with module fields (elastic#13544)
4f96543 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in elastic#13433 with
other metricsets.

Fix elastic#13432

(cherry picked from commit b2ead08)
jsoriano added a commit that referenced this pull request Sep 9, 2019
@jsoriano
Fix conversion of events with module fields (#13544) (#13552)
e0bb1c1 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in #13433 with
other metricsets.

Fix #13432

(cherry picked from commit b2ead08)
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 9, 2019
@jsoriano
Fix conversion of events with module fields (elastic#13544)
46ede79 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in elastic#13433 with
other metricsets.

Fix elastic#13432

(cherry picked from commit b2ead08)
jsoriano added a commit that referenced this pull request Sep 10, 2019
@jsoriano
Fix conversion of events with module fields (#13544) (#13553)
048aacd 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in #13433 with
other metricsets.

Fix #13432

(cherry picked from commit b2ead08)
jsoriano added a commit that referenced this pull request Sep 10, 2019
@jsoriano
Fix conversion of events with module fields (#13544) (#13554)
153c5c9 
Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in #13433 with
other metricsets.

Fix #13432

(cherry picked from commit b2ead08)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Cherry-pick elastic#13433 to 7.2: Fix conversions of events with modu…
1d0c15b 
…le fields (elastic#13442)

Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432

(cherry picked from commit 71fb53e)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Fix conversion of events with module fields (elastic#13544) (elastic#…
b41478f 
…13554)

Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in elastic#13433 with
other metricsets.

Fix elastic#13432

(cherry picked from commit 54860f7)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Cherry-pick elastic#13433 to 7.4: Fix conversions of events with modu…
0b46303 
…le fields (elastic#13440)

Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432

(cherry picked from commit 71fb53e)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Fix conversion of events with module fields (elastic#13544) (elastic#…
990cba4 
…13552)

Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in elastic#13433 with
other metricsets.

Fix elastic#13432

(cherry picked from commit 54860f7)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Cherry-pick elastic#13433 to 7.3: Fix conversions of events with modu…
7362aa6 
…le fields (elastic#13441)

Metricsets that use special fields like `ModuleDataKey` cannot be
directly used as metricset fields of `mb.Event`, they need to be
converted using something like the `mb.TransformMapStrToEvent()`
helper.

Fix elastic#13432

(cherry picked from commit 71fb53e)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Fix conversion of events with module fields (elastic#13544) (elastic#…
631bfcc 
…13553)

Use `TransformMapStrToEvent` also to convert events in the
kubernetes `state_node` metricset, as was done in elastic#13433 with
other metricsets.

Fix elastic#13432

(cherry picked from commit 54860f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@jsoriano jsoriano

Labels
bug Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan v7.2.2 v7.3.2 v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some metricbeat modules are incorrectly reporting module fields
3 participants
@jsoriano @ChrsMark @andresrc