-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Update CoreDNS pipelines for ECS DNS #13505
[Filebeat] Update CoreDNS pipelines for ECS DNS #13505
Conversation
42b0544
to
e3c6446
Compare
This sets the ECS DNS fields. It does not remove the coredns.* fields to avoid introducing a breaking change. Relates elastic#13320
e3c6446
to
23e65a1
Compare
Pinging @elastic/siem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create an issue to remember removing the duplicated coredns fields on 8.0?
There one unrelated failure on Jenkins/Linux/libbeat:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things and we're good to go!
- set: | ||
if: ctx.dns?.question?.name != null | ||
field: coredns.query.name | ||
value: '{{dns.question.name}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add the registered_domain
processor, to set dns.question.registered_domain
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will take some refactoring because all of the processing is happening in Ingest Node with this pipeline. To use the Beat's registered_domain
I'll need to move some of the dissecting to Beats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, with all the YAML, I hadn't actually noticed that this was an ingest pipeline :-)
Let's call this out of scope for now, then?
], | ||
"dns.id": "6966", | ||
"dns.question.class": "IN", | ||
"dns.question.name": "httpbin.org.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the trailing dot from domain lookups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This sets the ECS DNS fields. It does not remove the coredns.* fields to avoid introducing
a breaking change.
Relates #13320