Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in_cluster from doc examples #13651

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Sep 12, 2019

This configuration was removed by #13051.

This PR is clean up for any remaining references of this configuration filed.
Kudos to @jsoriano for bringing this up in #13473

cc: @odacremolbap, @exekias

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added docs containers Related to containers use case [zube]: In Review Team:Integrations Label for the Integrations team labels Sep 12, 2019
@ChrsMark ChrsMark requested a review from a team as a code owner September 12, 2019 13:40
@ChrsMark ChrsMark self-assigned this Sep 12, 2019
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM.

I think that we should add a breaking change note too to the changelog after #13051, could you add it here?

And we should also backport the change to 7.4.

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. review v7.4.0 labels Sep 12, 2019
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from jsoriano September 13, 2019 06:32
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@ChrsMark ChrsMark requested a review from jsoriano September 13, 2019 14:16
@ChrsMark ChrsMark merged commit 19da163 into elastic:master Sep 16, 2019
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Sep 16, 2019
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Sep 16, 2019
ChrsMark added a commit that referenced this pull request Sep 16, 2019
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Apr 8, 2020
mgreau pushed a commit to elastic/helm-charts that referenced this pull request Apr 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case docs review Team:Integrations Label for the Integrations team v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants