-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable add_kubernetes_metadata
if no matchers found
#13709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I think that in any case we have to do this after #13473. I don't think we should add default matchers to all beats, it may not make any sense in some of them.
I was wondering why you moved the code from before the checks for the client configuration (and not only replacing the current error), but it is probably ok because users can define their own indexers and matchers in the configuration.
I think that in any case we could also remove add_kubernetes_metadata
from the configuration files of beats without default indexers and matchers (for example with conditions as done here).
Also we have to take into account that we are removing the kubernetes and docker code from builds of platforms without docker support (see #13509), this will make all beats to badly fail on startup with default configuration on these platforms, as these processors won't exist. Not sure what to do about this, maybe we should reconsider #13068.
926b300
to
178daca
Compare
Jaime thank you for commenting on this. I think this is reviewable now and we can handle extra concerns in follow-ups as I proposed on #13705. |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
178daca
to
d90c756
Compare
Thanks for helping with this guys! |
Fixes #13705
As far as I can see, the problem with Beats other than Filebeat and Metricbeat is that they do not have default matchers. In the docs is mentioned that Filebeat enables
logs_path
matcher by default (Metricbeat, enablesfield
matcher).I'm not sure if we should add default matchers for all other Beats.
I think that ignoring that error and just disable the processor should be ok.
@jsoriano how it sounds to you?
cc: @andrewkroh