Support usage of custom builders without hints and mappers #13839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
vjsamuel
force-pushed
the
support_custom_builders
branch
from
6dace9c to
841d37e
Compare
|
The config construction is relatively complex. Maybe we should add a test, to prevent further regressions in the future. |
vjsamuel
force-pushed
the
support_custom_builders
branch
from
841d37e to
ce6d0c6
Compare
|
@urso i have added the missing test case. |
vjsamuel
force-pushed
the
support_custom_builders
branch
from
ce6d0c6 to
1db1cd5
Compare
vjsamuel
force-pushed
the
support_custom_builders
branch
from
1db1cd5 to
79c6e91
Compare
exekias
approved these changes
Oct 25, 2019
|
ok to test |
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
…3839) * Support usage of custom builders without hints and mappers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code expects for a mapping template or hints to be enabled. There are cases where custom builders can be used which is enough to make autodiscover work. This PR allows that. This used to work but for some reason it is broken now.