[6.8] Check if file has disappeared sooner in Log reader (#13907) #13960
Conversation
|
jenkins, test this |
|
@urso The CI failure is now fixed so this is ready for another review from you, when you get a chance, please. Thanks! |
|
jenkins, test this |
ycombinator
force-pushed
the
backport/6.8/pr-13907
branch
from
b7343d8 to
d5e0075
Compare
| @@ -25,3 +25,4 @@ type File struct { | |||
|
|
|||
| func (File) Continuable() bool { return true } | |||
| func (File) HasState() bool { return true } | |||
| func (f File) Removed() bool { return isRemoved(f.File) } | |||
There was a problem hiding this comment.
exported method File.Removed should have comment or be unexported
| @@ -25,3 +25,4 @@ type File struct { | |||
|
|
|||
| func (File) Continuable() bool { return true } | |||
| func (File) HasState() bool { return true } | |||
| func (f File) Removed() bool { return isRemoved(f.File) } | |||
There was a problem hiding this comment.
exported method File.Removed should have comment or be unexported
| @@ -44,3 +44,4 @@ func (p Pipe) Name() string { return p.File.Name() } | |||
| func (p Pipe) Stat() (os.FileInfo, error) { return p.File.Stat() } | |||
| func (p Pipe) Continuable() bool { return false } | |||
| func (p Pipe) HasState() bool { return false } | |||
| func (p Pipe) Removed() bool { return false } | |||
There was a problem hiding this comment.
exported method Pipe.Removed should have comment or be unexported
| @@ -25,3 +25,4 @@ type File struct { | |||
|
|
|||
| func (File) Continuable() bool { return true } | |||
| func (File) HasState() bool { return true } | |||
| func (f File) Removed() bool { return isRemoved(f.File) } | |||
There was a problem hiding this comment.
exported method File.Removed should have comment or be unexported
ycombinator
force-pushed
the
backport/6.8/pr-13907
branch
from
43cf306 to
bf7609b
Compare
* Adding comment about EOF and removing redundant logic * Adding debug logging when close_remove and close_renamed situations are reached * Check file stats related errors before adding to buffer * Reordering checks to be same as before * Add CHANGELOG entry * Fixing issue # in CHANGELOG entry * Move CloseInactive and truncate checks back to being after EOF check * Don't perform stat call for CloseRemoved/CloseRenamed unless those settings are enabled * Better comments / function godoc * Renaming method to be more descriptive * Fixing up CHANGELOG
ycombinator
force-pushed
the
backport/6.8/pr-13907
branch
from
bf7609b to
1acdccf
Compare
|
Travis CI is green but Jenkins CI is not. However, the only build that are failing in Jenkins CI is X-Pack/Metricbeat on Linux. The 6.8 X-Pack/Metricbeat on Linux build hasn't been green for as long as we have history for that build: https://beats-ci.elastic.co/job/elastic+beats+6.8+multijob-linux/beat=x-pack%2Fmetricbeat,label=linux-immutable/. Since this failure is unrelated to this PR, I'm going ahead and merging it now. |
Backports the following commits to 6.8: