-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance counter values #14039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
Metricbeat
Metricbeat
Team:Integrations
Label for the Integrations team
labels
Oct 14, 2019
jsoriano
reviewed
Oct 15, 2019
jsoriano
approved these changes
Oct 15, 2019
CHANGELOG.next.asciidoc
Outdated
@@ -171,6 +171,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
- Fix NPEs / resource leaks when executing config checks. {pull}11165[11165] | |||
- Fix duplicated IPs on `mode: all` monitors. {pull}12458[12458] | |||
- Fix integer comparison on JSON responses. {pull}13348[13348] | |||
- Fix performance counter values for windows/perfmon metricset.{issue}14036[14036] {pull}14039[14039] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is under the wrong session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good now
exekias
approved these changes
Oct 16, 2019
kaiyan-sheng
approved these changes
Oct 16, 2019
narph
added a commit
to narph/beats
that referenced
this pull request
Oct 17, 2019
* Fix counter values * Update changelog * Fix changelog entry (cherry picked from commit af8da88)
narph
added a commit
that referenced
this pull request
Oct 17, 2019
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
* Fix counter values * Update changelog * Fix changelog entry
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Fix performance counter values (elastic#14039) * Fix counter values * Update changelog * Fix changelog entry (cherry picked from commit dbcb458) * Cleanup changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #14036.
Calling PdhCollectQueryData a second time in less than one sec before retrieving counter values will affect the values returned.