Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance counter values #14039

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Fix performance counter values #14039

merged 3 commits into from
Oct 16, 2019

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 14, 2019

Should fix #14036.
Calling PdhCollectQueryData a second time in less than one sec before retrieving counter values will affect the values returned.

@narph narph added Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Oct 14, 2019
@narph narph requested a review from a team as a code owner October 14, 2019 17:15
@narph narph self-assigned this Oct 14, 2019
@narph narph requested a review from jsoriano October 15, 2019 08:21
@narph narph requested a review from jsoriano October 15, 2019 11:47
@@ -171,6 +171,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Fix NPEs / resource leaks when executing config checks. {pull}11165[11165]
- Fix duplicated IPs on `mode: all` monitors. {pull}12458[12458]
- Fix integer comparison on JSON responses. {pull}13348[13348]
- Fix performance counter values for windows/perfmon metricset.{issue}14036[14036] {pull}14039[14039]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is under the wrong session?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@narph narph merged commit af8da88 into elastic:master Oct 16, 2019
narph added a commit to narph/beats that referenced this pull request Oct 17, 2019
* Fix counter values

* Update changelog

* Fix changelog entry

(cherry picked from commit af8da88)
narph added a commit that referenced this pull request Oct 17, 2019
* Fix performance counter values  (#14039)

* Fix counter values

* Update changelog

* Fix changelog entry

(cherry picked from commit af8da88)

* Cleanup changelog
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
* Fix counter values

* Update changelog

* Fix changelog entry
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Fix performance counter values  (elastic#14039)

* Fix counter values

* Update changelog

* Fix changelog entry

(cherry picked from commit dbcb458)

* Cleanup changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrealistic Data after implementing the Refresh Counter List
5 participants