Negotiate Docker API version in client #14115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libbeat Docker client wasn't negotiate the Docker API version after updating the Docker package versions. This changes the Docker client to use the `NewClientWithOpts` function rather than the deprecated `NewClient` function. When the client is constructed we will pass in the `WithAPIVersionNegotiation` option if no version is explicitly configured in the DOCKER_API_VERSION environment variable. Upon the first request the client will negotiate the API version. Fixes changes made in elastic#13415.
andrewkroh
force-pushed
the
bugfix/docker-api-negotiate
branch
from
94c3ee3
to
1ad8034
Compare
andrewkroh
added
the
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Oct 21, 2019
The libbeat Docker client wasn't negotiate the Docker API version after updating the Docker package versions. This changes the Docker client to use the `NewClientWithOpts` function rather than the deprecated `NewClient` function. When the client is constructed we will pass in the `WithAPIVersionNegotiation` option if no version is explicitly configured in the DOCKER_API_VERSION environment variable. Upon the first request the client will negotiate the API version. Fixes changes made in elastic#13415. (cherry picked from commit ca6dc3a)
andrewkroh
added
v7.5.0
and removed
needs_backport
andrewkroh
added a commit
that referenced
this pull request
Oct 26, 2019
The libbeat Docker client wasn't negotiate the Docker API version after updating the Docker package versions. This changes the Docker client to use the `NewClientWithOpts` function rather than the deprecated `NewClient` function. When the client is constructed we will pass in the `WithAPIVersionNegotiation` option if no version is explicitly configured in the DOCKER_API_VERSION environment variable. Upon the first request the client will negotiate the API version. Fixes changes made in #13415. (cherry picked from commit ca6dc3a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
The libbeat Docker client wasn't negotiate the Docker API version after updating the Docker package versions. This changes the Docker client to use the `NewClientWithOpts` function rather than the deprecated `NewClient` function. When the client is constructed we will pass in the `WithAPIVersionNegotiation` option if no version is explicitly configured in the DOCKER_API_VERSION environment variable. Upon the first request the client will negotiate the API version. Fixes changes made in elastic#13415. (cherry picked from commit a647b0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libbeat Docker client wasn't negotiating the Docker API version after updating the Docker package versions. This changes the Docker client to use the
NewClientWithOptsfunction rather than the deprecatedNewClientfunction.When the client is constructed we will pass in the
WithAPIVersionNegotiationoption if no version is explicitly configured in the DOCKER_API_VERSION environment variable. Upon the first request the client will negotiate the API version.Fixes changes made in #13415.