Replace mapval with go-lookslike #14165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some tech debt since the mapval package has been renamed and moved to https://github.com/elastic/go-lookslike , we should stop using the now older/outdated mapval package.
andrewkroh
approved these changes
Oct 21, 2019
CHANGELOG-developer.next.asciidoc
Outdated
| @@ -25,6 +25,7 @@ The list below covers the major changes between 7.0.0-rc2 and master only. | |||
| - Build docker and kubernetes features only on supported platforms. {pull}13509[13509] | |||
| - Need to register new processors to be used in the JS processor in their `init` functions. {pull}13509[13509] | |||
| - The custom beat generator now uses mage instead of python, `mage GenerateCustomBeat` can be used to create a new beat, and `mage vendorUpdate` to update the vendored libbeat in a custom beat. {pull}13610[13610] | |||
| - Altered all remaining uses of mapval to use the renamed and enhanced version: [go-lookslike](https://github.com/elastic/go-lookslike) instead, which is a separate project. The mapval tree is now gone. {pull}14165[14165] | |||
There was a problem hiding this comment.
Just checking if this is asciidoc syntax? Lookslike markdown.
There was a problem hiding this comment.
Ah, good catch, will fix!
|
jenkins, retest this please |
|
jenkins, test this please |
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
This cleans up some tech debt since the mapval package has been renamed and moved to https://github.com/elastic/go-lookslike , we should stop using the now older/outdated mapval package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some tech debt since the mapval package has been renamed
and moved to https://github.com/elastic/go-lookslike , we should stop
using the now older/outdated mapval package.