Add elasticsearch/enrich metricset
#14243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
force-pushed
the
mb-es-enrich
branch
from
2b8e5a5 to
bee2da4
Compare
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
cachedout
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
This looks really good. I have verified this functionally using the steps provided and it works as described. I have also verified by hand that the documents produced by this PR line up with the fields that we are gathering via internal collection. I reviewed the code as well and found no concerns.
jsoriano
approved these changes
Oct 29, 2019
|
Travis CI is green. Jenkins CI failures are unrelated. Merging... |
ycombinator
added a commit
that referenced
this pull request
Oct 29, 2019
* Add `elasticsearch/enrich` metricset (#14243) * WIP: elasticsearch/enrich metricset * Adding non-xpack event creation * More changes * Adding docs.asciidoc * Running make update * Adding missing file * Adding data.json * Implement xpack.enabled: true event creation * Adding missing import * Remove license check as enrich is available in basic * Skip enrich integration test against ES versions < 7.5.0 * Skip system tests for enrich metricset with ES < 7.5.0 * Adding integration test * Updating data.json * Adding CHANGELOG entry * Adding system test * Fixing up system tests * Cleanup! * Only try to create enrich stats if enrich feature is available * Fixing skip logic * Fixing up CHANGELOG
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
* WIP: elasticsearch/enrich metricset * Adding non-xpack event creation * More changes * Adding docs.asciidoc * Running make update * Adding missing file * Adding data.json * Implement xpack.enabled: true event creation * Adding missing import * Remove license check as enrich is available in basic * Skip enrich integration test against ES versions < 7.5.0 * Skip system tests for enrich metricset with ES < 7.5.0 * Adding integration test * Updating data.json * Adding CHANGELOG entry * Adding system test * Fixing up system tests * Cleanup! * Only try to create enrich stats if enrich feature is available * Fixing skip logic
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…4302) * Add `elasticsearch/enrich` metricset (elastic#14243) * WIP: elasticsearch/enrich metricset * Adding non-xpack event creation * More changes * Adding docs.asciidoc * Running make update * Adding missing file * Adding data.json * Implement xpack.enabled: true event creation * Adding missing import * Remove license check as enrich is available in basic * Skip enrich integration test against ES versions < 7.5.0 * Skip system tests for enrich metricset with ES < 7.5.0 * Adding integration test * Updating data.json * Adding CHANGELOG entry * Adding system test * Fixing up system tests * Cleanup! * Only try to create enrich stats if enrich feature is available * Fixing skip logic * Fixing up CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14221.
This PR adds a new
enrichmetricset to theelasticsearchMetricbeat module. This metricset is responsible for collecting stats from theGET _enrich/_statsElasticsearch API. It's primarily intended to be used for Stack Monitoring, i.e. with thexpack.enabledflag set totruein theelasticsearchmodule configuration.Testing this PR
Build Metricbeat with this PR.
Enable the
elasticsearch-xpackmodule. This module configuration contains theenrichmetricset.Run Metricbeat.
Follow the 6 steps at https://www.elastic.co/guide/en/elasticsearch/reference/7.x/ingest-enriching-data.html to ingest a document and have Elasticsearch enrich it. This will generate some enrich stats.
Give the
elasticsearch/enrichmetricset up to 10 seconds to collect enrich stats and index them.Verify that the
.monitoring-es-*indices contains enrich stats documents.