Ensure that init containers are no longer tailed after they stop

[vjsamuel]

Init containers are killed off immediately after their work is done. So, ideally we should stop polling their endpoints and tailing their log files. The lack of this check impacted one of our builders that didnt have container in the log file path. Which caused the same path to be tailed multiple times.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[odacremolbap]

Thanks @vjsamuel

Can you add a changelog entry?
Let me spend some time to manually test

[vjsamuel]

thanks @odacremolbap. I have done the needful.

[odacremolbap]

@vjsamuel sorry for the multi-step review.

tests are failing because container status are not being informed at a "start" pod test.

Adding ContainerStateRunning to that test solved the issue.
Would you mind adding a fix for the test along this lines:

diff --git a/libbeat/autodiscover/providers/kubernetes/kubernetes_test.go b/libbeat/autodiscover/providers/kubernetes/kubernetes_test.go
index fdd71e799..59e69038f 100644
--- a/libbeat/autodiscover/providers/kubernetes/kubernetes_test.go
+++ b/libbeat/autodiscover/providers/kubernetes/kubernetes_test.go
@@ -23,7 +23,7 @@ import (

        "github.com/gofrs/uuid"
        "github.com/stretchr/testify/assert"
-       "k8s.io/api/core/v1"
+       v1 "k8s.io/api/core/v1"
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
        "k8s.io/apimachinery/pkg/types"

@@ -198,6 +198,9 @@ func TestEmitEvent(t *testing.T) {
                                                {
                                                        Name:        name,
                                                        ContainerID: containerID,
+                                                       State: v1.ContainerState{
+                                                               Running: &v1.ContainerStateRunning{},
+                                                       },
                                                },
                                        },
                                },

(note: that "v1" import at my example depends on goimports configured at my IDE, no need to change that)

[odacremolbap]

can you fix tests as depicted here?

[vjsamuel]

@odacremolbap done. thanks for debugging the build failure.

[odacremolbap]

@vjsamuel LGTM
thanks a ton for your involvement into beats