Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ID processor #14524
Add ID processor #14524
Changes from 46 commits
e0dc306
4269333
bfa27b1
98a891d
1133141
f35064b
f6ed19c
e2d85fe
477fe7f
998a85f
e4a2af6
229d57d
c9a7bae
4cc8c56
a6b3646
950cd5b
02cdbf6
6881da2
b3af9e8
ae02eb2
b60e88c
881c040
f405381
7245204
3f9652a
63fe346
63a96fc
fc0e6bb
539188d
ef1e22c
848c35e
6d604d9
c89d3c4
1e62ad7
fb6e89d
e00cb7b
439b56f
92637a5
b7fe6fb
d45e591
0a76462
1b44e75
aa8739b
7c79403
99c01b7
e4f9fe9
f2faf14
51f8eed
72b97c5
5e8420c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somewhere we should document that the Elasticsearch output will use
@metadata.id
as document ID if present. Plus we should document on how users can use the field if sending via Logstash.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I was initially thinking of doing this in a blog post (that would cover the introduction of this processor and the
fingerprint
processor, from a use case perspective). But I think it's useful to have this in our docs somewhere as well, since users will be looking at those more over time.I wonder if this sort of documentation belongs in the ES output and LS output docs, since it's strictly agnostic to what generated the ID (e.g. this processor, but could be something else too). @dedemorton WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ycombinator I'm planning to work on a related issue this week: #13739. We should talk about your plans for the blog post and see what makes sense for the docs. I'd like to avoid burying the content too deeply under the config settings. I think we need a topic that describes what the document ID is (with links to the ES docs), how it's set, and why you want to set it (deduplication etc). Maybe we can chat later this week.