Remove deprecated 'host' option #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| The port of the Elasticsearch server. This option is deprecated because it is replaced by <<hosts-option>>. | ||
| The default port of the Elasticsearch server. |
There was a problem hiding this comment.
Should this say that the default is 9200 if not specified?
There was a problem hiding this comment.
yeah, was still unsure about this options as it said 'deprecated'.
Current coverage is 33.34%@@ master #1474 diff @@
==========================================
Files 55 55
Lines 4238 4238
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1413 1413
Misses 2717 2717
Partials 108 108
|
remove support for deprecated `host` option in elasticsearch, logstash, kafka and redis output.
|
LGTM. Waiting for green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove support for deprecated
hostoption in elasticsearch, logstash, kafkaand redis output.