Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winlogbeat - fix large message panic for Windows Vista and newer #1499

Merged
merged 1 commit into from
Apr 27, 2016

Commits on Apr 27, 2016

  1. Fix panic that occurs when reading a large events on Windows Vista an…

    …d newer.
    
    This occurs in an error recovery path so in order for the panic to occur, first there had to have been an error rendering the event as XML with the event message string. When that error occurs Winlogbeat tries to render the event as XML, but without the message string. If the XML was larger than half the buffer size a panic would occur.
    
    The cause was invalid handling of the "BufferUsed [out]" parameter value. The value specifies the number of bytes in this case and it was treated as if it where the number of characters. This is opposite of the behavior of FormatMessage() used in earlier versions of Windows which returns the number of characters rather than bytes.
    andrewkroh committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    16738a0 View commit details
    Browse the repository at this point in the history