[7.x] Add ID processor (#14524) #15041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP: Flake ID processor * Fleshing out implementation of generator * Rename package * Unexport const * Use increment operator * Adding processor scaffolding * Fixing default field * Adding CHANGELOG entry * Fixing compile errors * WIP: unit tests * Fixing byte copy * Fixing up tests * Adding test TODOs * Adding non-default target field unit test * Adding one more test TODO * Adding TODO for post-benchmarking * Introduce type * Adding unit test for factory * Adding unit test for mac * Adding unit test for mac * Fleshing out remaining mac unit tests * Adding tests for ES ID generator * Remove TODO after experimenting with IIFE (perf was worse) * Moving doc * Adding UUID processor to list in docs * Apply suggestions from docs code review Co-Authored-By: DeDe Morton <dede.morton@elastic.co> * Adding godoc * Rename generator function type * Exporting and adding godoc * Adding godoc * Updating godoc * Adding Unwrap error methods * Moving ES ID generator into generators package + singleton construction * Addressing Hound feedback * Renaming processor to `add_id` * Updating processor name in CHANGELOG entry * More refactoring updates * Fixing more vet errors * Unexport config struct as it's only used within this package * Fixing doc anchor * Moving generator construction to processor constructor; simplifying factory * Fixing compile error * Validate ID generator type in config * Finer-grained locking to reduce mutex contention * Initialize package global variables that depend on randomness, later * Compute last timestamp while accounting for system time going backwards * Simpler and testable timestamp() function * Adding unit test for timestamp function * Re-implementing ES timestamp algorithm * Removing unused variable
houndci-bot
reviewed
Dec 11, 2019
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
houndci-bot
reviewed
Dec 11, 2019
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
houndci-bot
reviewed
Dec 11, 2019
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package add_id |
There was a problem hiding this comment.
don't use an underscore in package name
ycombinator
requested review from
dedemorton,
afoucret and
urso
and removed request for
afoucret
urso
approved these changes
Dec 11, 2019
|
Travis CI is green. Jenkins CI failures are unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: