Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #15847 to 7.x: Use RFC3339 format for timestamps in SQL module #15855

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

jsoriano
Copy link
Member

Cherry-pick of PR #15847 to 7.x branch. Original message:

What does this PR do?

Format timestamps collected with the SQL module using the RFC3339 Nano format,
that includes the timezone and is a more precise representation.

Why is it important?

So timezone information and precission is not lost when formatting the timestamps
for the final event.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

This way timezone and more precise information is stored in the final
events in case they are lately parsed as dates.

(cherry picked from commit 121f19d)
@jsoriano jsoriano requested a review from a team as a code owner January 27, 2020 11:53
@jsoriano jsoriano merged commit a7c3591 into elastic:7.x Jan 27, 2020
@jsoriano jsoriano deleted the backport_15847_7.x branch January 27, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants