Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Re-factor to fix high CPU usage on windows (#1562) #1598

Merged
merged 1 commit into from
May 10, 2016
Merged

Backport: Re-factor to fix high CPU usage on windows (#1562) #1598

merged 1 commit into from
May 10, 2016

Commits on May 9, 2016

  1. Re-factor to fix high CPU usage on windows (elastic#1562) 

    * Re-factor to fix high CPU usage on windows

This decouples getting the basic state information from getting the more
detailed information.  The reason is that filtering only needs the name, but
the code was getting all details and then apply filtering. Getting the command
line is expensive on Windows, so that contributed to elastic#1460.

What made it worse is that due to filtering, the command line cache was
invalidated on each run, which explains why topbeat was consuming more CPU when
filtering out processes than when not.

Fixes elastic#1460.

This also pre-compiles the regexps, which brings some slight CPU usage improvements
and uncovers compilation errors earlier.
    @tsg
    tsg authored and Tudor Golubenco committed May 9, 2016
    Configuration menu
    Copy the full SHA
    e5b00c6 View commit details
    Browse the repository at this point in the history