Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16199 to 7.x: Upgrade go-ucfg to version 0.8.2 #16304

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #16199 to 7.x branch. Original message:

What does this PR do?

Upgrades go-ucfg to version 0.8.2. (Currently this is pointing to master to get a full test run before releasing go-ucfg at version 0.8.2).

Why is it important?

Includes the following fixes:

  • Fixed nonzero validator to not fail on nil array or slice.
  • Fixed nonzero validator to validate maps.
  • Fixed required validator to validate maps.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

* Upgrade go-ucfg to master, for testing before 0.8.2 release.

* Update notice.

* Fix tests.

* Update to the v0.8.2 release tag and remake NOTICE.txt.

* Improve test name.

(cherry picked from commit f9403ce)
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for splitting up the backport into two PRs, appreciate it — made the reviews pretty straightforward for me.

@blakerouse blakerouse merged commit 733db53 into elastic:7.x Feb 13, 2020
@blakerouse blakerouse deleted the backport_16199_7.x branch February 13, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants