Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #15059 to 7.x: Add metricbeat iis module #16690

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Cherry-pick #15059 to 7.x: Add metricbeat iis module #16690

merged 3 commits into from
Mar 2, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 28, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #15059 to 7.x branch. Original message:

Related issue #13072

Reusing the pdh query (in perfmon) to retrieve the iis specific counters.
Initial implementation contains 2 metricsets:

  • webserver - includes aggregated metrics over the entire IIS web server (light metricset based on the perfmon metricset)
  • website - includes metrics from each website running
  • application_pool - includes metrics for each application pool
- module: iis
  metricsets:
    - webserver
    - website
    - application_pool
  enabled: true
  period: 10s

 # filter on application pool names
 # application_pool.name: []

@narph
Add metricbeat iis module (elastic#15059)
de99385 
* created iis module

* work in progress

* iis changes

* add iis module

* light

* work on build

* work on build

* build

* fmt update

* temp

* work on website

* temp

* temp

* manifest changes

* temp

* temp

* work on wp

* adding application pool metricset

* wmi option

* test

* work on apppool

* work on app pool

* work on website metricset

* work on tests

* Work on website

* work on website

* work on website

* perfmon fix

* work on websie

* update config

* feedback

* work on feedback

* temp

* ecs

* temp

* add counters

(cherry picked from commit 8be4589)
@narph narph requested a review from a team as a code owner February 28, 2020 16:21
@narph narph self-assigned this Feb 28, 2020
@narph narph added backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team [zube]: In Review labels Feb 28, 2020
kaiyan-sheng
kaiyan-sheng approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be missing a changelog in the original PR. Other than that, this looks good to me.

@narph narph merged commit ab75f47 into elastic:7.x Mar 2, 2020
@narph narph deleted the backport_15059_7.x branch March 2, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @kaiyan-sheng @andresrc