-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debugging dump option to Jenkins #16758
Conversation
I'd call the method |
You might also want to work in a call to |
yep that looks more accurate |
In-addition-to or in-place-of what's there now? |
@kuisathaverat OK, this is ready for another round of review. Thanks! |
jenkins, run the tests please |
@andrewkroh Looks like this has some unrelated failures. Could you give it a review and let me know if you think it's safe to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Merging after verifying it is OK with the Beats team. |
it has a syntax issue
|
Shoot! Probably on L45. Are you putting up a PR or shall I do it? |
What does this PR do?
Why is it important?
This allows for easier debugging of Jenkins errors by providing an option to dump certain environment variables to the console.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
Related issues