Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugging dump option to Jenkins #16758

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Conversation

cachedout
Copy link
Contributor

What does this PR do?

Why is it important?

This allows for easier debugging of Jenkins errors by providing an option to dump certain environment variables to the console.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

Related issues

Jenkinsfile Outdated Show resolved Hide resolved
@kuisathaverat
Copy link
Contributor

I'd call the method dumpFilteredEnvironment inside those tho functions to show the env vars before to execute a target

https://github.com/elastic/beats/blob/d2b4cc4c9cf183a642df55035e8cb53665370337/Jenkinsfile#L549-L572

Jenkinsfile Outdated Show resolved Hide resolved
@andrewkroh
Copy link
Member

You might also want to work in a call to mage dumpVariables if you think it fits in to what your doing.

@kuisathaverat
Copy link
Contributor

You might also want to work in a call to mage dumpVariables if you think it fits in to what your doing.

yep that looks more accurate

@cachedout
Copy link
Contributor Author

You might also want to work in a call to mage dumpVariables if you think it fits in to what your doing.

In-addition-to or in-place-of what's there now?

@cachedout cachedout requested a review from kuisathaverat March 4, 2020 12:22
@cachedout
Copy link
Contributor Author

@kuisathaverat OK, this is ready for another round of review. Thanks!

@cachedout
Copy link
Contributor Author

jenkins, run the tests please

@cachedout cachedout requested a review from andrewkroh March 9, 2020 10:34
@cachedout
Copy link
Contributor Author

@andrewkroh Looks like this has some unrelated failures. Could you give it a review and let me know if you think it's safe to merge?

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cachedout
Copy link
Contributor Author

Merging after verifying it is OK with the Beats team.

@cachedout cachedout merged commit 5bd84ae into elastic:master Mar 11, 2020
@cachedout cachedout deleted the issue_602 branch March 11, 2020 10:37
@kuisathaverat
Copy link
Contributor

it has a syntax issue

11:19:44  GitHub has been notified of this commit’s build result
11:19:44  
11:19:44  org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
11:19:44  WorkflowScript: 532: unexpected token: } @ line 532, column 1.
11:19:44     }
11:19:44     ^

@cachedout
Copy link
Contributor Author

Shoot! Probably on L45. Are you putting up a PR or shall I do it?

@kuisathaverat
Copy link
Contributor

#16975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants