Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16754 to 7.x: Move azure module to GA #16793

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Cherry-pick #16754 to 7.x: Move azure module to GA #16793

merged 1 commit into from
Mar 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 4, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #16754 to 7.x branch. Original message:

Should fix some of the points in #16024

  • moved azure.resource.name to cloud.instance.name
  • added cloud.instance.id and cloud.machine.type (mapping the resource size for compute_vm and compute_vm_scaleset)
  • added more integration tests and generated the data.json files
  • modified dashboards based on the new fields

@narph
Move azure module to GA (elastic#16754)
9f5f35f 
* work on GA

* mage fmt

* fix

* work on tests

* fix

* work on tests

* generate from test

(cherry picked from commit 1894441)
@narph narph requested a review from a team as a code owner March 4, 2020 11:46
@narph narph self-assigned this Mar 4, 2020
@narph narph added backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team [zube]: In Review labels Mar 4, 2020
@narph narph merged commit 939a426 into elastic:7.x Mar 4, 2020
@narph narph added the v7.7.0 label Mar 4, 2020
@narph narph deleted the backport_16754_7.x branch March 4, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @ChrsMark @andresrc