Install full configs in packages #1682
Conversation
This adds the "full" version of the configuration files to the config path of all the artifacts.
| # Windows | ||
| sed -i 's|#\{0,1\}\(to_files:\).*|\1 true|' $(PREFIX)/$(BEATNAME)-win.yml | ||
| sed -i 's|#\{0,1\}\(level:\).*|\1 info|' $(PREFIX)/$(BEATNAME)-win.yml | ||
| sed -i '/log files/{n;s|#\{0,1\}path:.*|path: C:/ProgramData/winlogbeat/Logs|}' $(PREFIX)/$(BEATNAME)-win.yml |
There was a problem hiding this comment.
@andrewkroh I removed these as the current defaults should work fine and I want to minimize the number of seds we do on the config files.
There was a problem hiding this comment.
The only thing I will miss here is having the info level logging out of the box. When you are new first time user it's nice to have some positive feedback in the logs that its running and indexing events.
There was a problem hiding this comment.
Yeah, I thought so, but that makes it inconsistent with the rest of the Beats. The reason we keep it to ERR is that WARN is too verbose in Packetbeat, maybe in other beats as well. Maybe we should move most of those WARNs to DEBUG and then switch to INFO by default.
I think our logging system, in general, is due for refactoring.
There was a problem hiding this comment.
I did in the past quite a few changes to filebeat and libbeat to make "INFO" feasible. +1 on switching to Info and do some refactoring of packetbeat. That would be also a win that the log file gets generated by default as there are always info messages on startup.
|
jenkins, package it |
| @@ -33,15 +33,15 @@ cp $BEATNAME.template-es2x.json $PREFIX/$BEATNAME.template-es2x.json | |||
|
|
|||
| # linux | |||
| cp $BEATNAME.yml $PREFIX/$BEATNAME-linux.yml | |||
There was a problem hiding this comment.
For linux we do not copy full?
|
LGTM |
|
@tsg @andrewkroh Merging this one as I assume we agree on improving the logging. I would even suggest to enabled info by default in a small PR and then tackle packetbeat? |
This adds the "full" version of the configuration files to the
config path of all the artifacts.